Re: [Intel-gfx] [PATCH] drm/i915: Simplify has_sagv function

2018-10-29 Thread Rodrigo Vivi
On Mon, Oct 29, 2018 at 12:08:38PM +0200, Jani Nikula wrote: > On Fri, 26 Oct 2018, Rodrigo Vivi wrote: > > The specially case for SKL for not controlled sagv > > is already taken care inside intel_enable_sagv, so there's > > no need to duplicate the check here. > > > > v2: Go one step further

Re: [Intel-gfx] [PATCH] drm/i915: Simplify has_sagv function

2018-10-29 Thread Jani Nikula
On Fri, 26 Oct 2018, Rodrigo Vivi wrote: > The specially case for SKL for not controlled sagv > is already taken care inside intel_enable_sagv, so there's > no need to duplicate the check here. > > v2: Go one step further and remove skl special case. (Jani) > v3: Separate runtime status handle

[Intel-gfx] [PATCH] drm/i915: Simplify has_sagv function

2018-10-26 Thread Rodrigo Vivi
The specially case for SKL for not controlled sagv is already taken care inside intel_enable_sagv, so there's no need to duplicate the check here. v2: Go one step further and remove skl special case. (Jani) v3: Separate runtime status handle from has_sagv flag. v4: Go back and accept simple Jani

Re: [Intel-gfx] [PATCH] drm/i915: Simplify has_sagv

2018-10-24 Thread Rodrigo Vivi
On Wed, Oct 24, 2018 at 01:13:51PM +0300, Jani Nikula wrote: > On Tue, 23 Oct 2018, Rodrigo Vivi wrote: > > But I thought while doing this I could consolidade it along with all > > the other has_feature cases. > > > > I believe we should either have everything as info.has_feature or everything >

Re: [Intel-gfx] [PATCH] drm/i915: Simplify has_sagv

2018-10-24 Thread Jani Nikula
On Tue, 23 Oct 2018, Rodrigo Vivi wrote: > But I thought while doing this I could consolidade it along with all > the other has_feature cases. > > I believe we should either have everything as info.has_feature or everything > as has_feature(). > > for instance if we end up ever having 2 platforms

Re: [Intel-gfx] [PATCH] drm/i915: Simplify has_sagv

2018-10-23 Thread Rodrigo Vivi
On Tue, Oct 23, 2018 at 10:23:39AM +0300, Jani Nikula wrote: > On Mon, 22 Oct 2018, Rodrigo Vivi wrote: > > Let's add a platform has_sagv instead of having a full > > function that handle platform by platform. > > > > The specially case for SKL for not controlled sagv > > is already taken care

Re: [Intel-gfx] [PATCH] drm/i915: Simplify has_sagv

2018-10-23 Thread Jani Nikula
On Mon, 22 Oct 2018, Rodrigo Vivi wrote: > Let's add a platform has_sagv instead of having a full > function that handle platform by platform. > > The specially case for SKL for not controlled sagv > is already taken care inside intel_enable_sagv, so there's > no need to duplicate the check here.

Re: [Intel-gfx] [PATCH] drm/i915: Simplify has_sagv

2018-10-22 Thread Paulo Zanoni
Em Seg, 2018-10-22 às 17:06 -0700, Rodrigo Vivi escreveu: > On Mon, Oct 22, 2018 at 04:48:50PM -0700, Paulo Zanoni wrote: > > Em Seg, 2018-10-22 às 09:57 -0700, Rodrigo Vivi escreveu: > > > Let's add a platform has_sagv instead of having a full > > > function that handle platform by platform. > >

Re: [Intel-gfx] [PATCH] drm/i915: Simplify has_sagv

2018-10-22 Thread Rodrigo Vivi
On Mon, Oct 22, 2018 at 04:48:50PM -0700, Paulo Zanoni wrote: > Em Seg, 2018-10-22 às 09:57 -0700, Rodrigo Vivi escreveu: > > Let's add a platform has_sagv instead of having a full > > function that handle platform by platform. > > > > The specially case for SKL for not controlled sagv > > is

Re: [Intel-gfx] [PATCH] drm/i915: Simplify has_sagv

2018-10-22 Thread Paulo Zanoni
Em Seg, 2018-10-22 às 09:57 -0700, Rodrigo Vivi escreveu: > Let's add a platform has_sagv instead of having a full > function that handle platform by platform. > > The specially case for SKL for not controlled sagv > is already taken care inside intel_enable_sagv, so there's > no need to

[Intel-gfx] [PATCH] drm/i915: Simplify has_sagv

2018-10-22 Thread Rodrigo Vivi
Let's add a platform has_sagv instead of having a full function that handle platform by platform. The specially case for SKL for not controlled sagv is already taken care inside intel_enable_sagv, so there's no need to duplicate the check here. v2: Go one step further and remove skl special

Re: [Intel-gfx] [PATCH] drm/i915: Simplify has_sagv

2018-10-22 Thread Jani Nikula
On Fri, 19 Oct 2018, Rodrigo Vivi wrote: > Let's add a platform has_sagv instead of having a full > function that handle platform by platform. > > The specially case for SKL for not controlled sagv > is already taken care inside intel_enable_sagv, so there's > no need to duplicate the check here.

[Intel-gfx] [PATCH] drm/i915: Simplify has_sagv

2018-10-19 Thread Rodrigo Vivi
Let's add a platform has_sagv instead of having a full function that handle platform by platform. The specially case for SKL for not controlled sagv is already taken care inside intel_enable_sagv, so there's no need to duplicate the check here. v2: Go one step further and remove skl special