Re: [Intel-gfx] [PATCH] drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection

2018-03-05 Thread Chris Wilson
Quoting Chris Wilson (2018-03-05 14:34:42) > Quoting Mika Kuoppala (2018-03-05 13:59:43) > > Chris Wilson writes: > > > > > Similar to the staging around handling of engine->submit_request, we > > > need to stop adding to the execlists->queue prior to calling > > >

Re: [Intel-gfx] [PATCH] drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection

2018-03-05 Thread Chris Wilson
Quoting Mika Kuoppala (2018-03-05 13:59:43) > Chris Wilson writes: > > > Similar to the staging around handling of engine->submit_request, we > > need to stop adding to the execlists->queue prior to calling > > engine->cancel_requests. cancel_requests will move requests

Re: [Intel-gfx] [PATCH] drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection

2018-03-05 Thread Mika Kuoppala
Chris Wilson writes: > Similar to the staging around handling of engine->submit_request, we > need to stop adding to the execlists->queue prior to calling > engine->cancel_requests. cancel_requests will move requests from the > queue onto the timeline, so if we add a

[Intel-gfx] [PATCH] drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection

2018-03-03 Thread Chris Wilson
Similar to the staging around handling of engine->submit_request, we need to stop adding to the execlists->queue prior to calling engine->cancel_requests. cancel_requests will move requests from the queue onto the timeline, so if we add a request onto the queue after that point, it will be lost.