Re: [Intel-gfx] [PATCH] drm/i915: Zap some empty lines
Hi Tvrtko, On Mon, Sep 25, 2023 at 03:28:27PM +0100, Tvrtko Ursulin wrote: > > On 25/09/2023 15:14, Andi Shyti wrote: > > Hi Tvrtko, > > > > On Wed, Sep 20, 2023 at 09:57:15AM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Recent refactoring left an unsightly block of empty lines. Remove them. > > > > > > Signed-off-by: Tvrtko Ursulin > > > Cc: Dnyaneshwar Bhadane > > > Cc: Anusha Srivatsa > > > Cc: Radhakrishna Sripada > > > > as this isn't merged yet: > > > > Reviewed-by: Andi Shyti > > Thanks, I am catching up with things and this wasn't so important. If you > have a spare moment feel free to push it? All right, pushed to drm-intel-next :) Thanks, Andi
Re: [Intel-gfx] [PATCH] drm/i915: Zap some empty lines
On 25/09/2023 15:14, Andi Shyti wrote: Hi Tvrtko, On Wed, Sep 20, 2023 at 09:57:15AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Recent refactoring left an unsightly block of empty lines. Remove them. Signed-off-by: Tvrtko Ursulin Cc: Dnyaneshwar Bhadane Cc: Anusha Srivatsa Cc: Radhakrishna Sripada as this isn't merged yet: Reviewed-by: Andi Shyti Thanks, I am catching up with things and this wasn't so important. If you have a spare moment feel free to push it? Regards, Tvrtko
Re: [Intel-gfx] [PATCH] drm/i915: Zap some empty lines
Hi Tvrtko, On Wed, Sep 20, 2023 at 09:57:15AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Recent refactoring left an unsightly block of empty lines. Remove them. > > Signed-off-by: Tvrtko Ursulin > Cc: Dnyaneshwar Bhadane > Cc: Anusha Srivatsa > Cc: Radhakrishna Sripada as this isn't merged yet: Reviewed-by: Andi Shyti Andi
Re: [Intel-gfx] [PATCH] drm/i915: Zap some empty lines
> -Original Message- > From: dri-devel On Behalf Of Tvrtko > Ursulin > Sent: Wednesday, September 20, 2023 2:27 PM > To: Intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Bhadane, Dnyaneshwar > ; Sripada, Radhakrishna > ; Ursulin, Tvrtko > Subject: [PATCH] drm/i915: Zap some empty lines > > From: Tvrtko Ursulin > > Recent refactoring left an unsightly block of empty lines. Remove them. > > Signed-off-by: Tvrtko Ursulin > Cc: Dnyaneshwar Bhadane > Cc: Anusha Srivatsa > Cc: Radhakrishna Sripada LGTM, Reviewed-by: Radhakrishna Sripada > --- > drivers/gpu/drm/i915/i915_drv.h | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 87ffc477c3b1..511eba3bbdba 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -646,13 +646,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, > #define IS_TIGERLAKE_UY(i915) \ > IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY) > > - > - > - > - > - > - > - > #define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \ > (IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until)) > > -- > 2.39.2
Re: [Intel-gfx] [PATCH] drm/i915: Zap some empty lines
On Wed, 20 Sep 2023, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Recent refactoring left an unsightly block of empty lines. Remove them. > > Signed-off-by: Tvrtko Ursulin > Cc: Dnyaneshwar Bhadane > Cc: Anusha Srivatsa > Cc: Radhakrishna Sripada One of the harder patches I've reviewed this week. Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 87ffc477c3b1..511eba3bbdba 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -646,13 +646,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, > #define IS_TIGERLAKE_UY(i915) \ > IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY) > > - > - > - > - > - > - > - > #define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \ > (IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until)) -- Jani Nikula, Intel
[Intel-gfx] [PATCH] drm/i915: Zap some empty lines
From: Tvrtko Ursulin Recent refactoring left an unsightly block of empty lines. Remove them. Signed-off-by: Tvrtko Ursulin Cc: Dnyaneshwar Bhadane Cc: Anusha Srivatsa Cc: Radhakrishna Sripada --- drivers/gpu/drm/i915/i915_drv.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 87ffc477c3b1..511eba3bbdba 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -646,13 +646,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, #define IS_TIGERLAKE_UY(i915) \ IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY) - - - - - - - #define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \ (IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until)) -- 2.39.2
