Re: [Intel-gfx] [PATCH] drm/i915: add register macro definition style guide

2017-08-09 Thread Pandiyan, Dhinakaran
On Fri, 2017-08-04 at 13:38 +0300, Jani Nikula wrote: > This is not to try to force a new style; this is my interpretation of > what the most common existing style is. > > With hopes I don't need to answer so many questions about style going > forward. > > Cc: Daniel Vetter

Re: [Intel-gfx] [PATCH] drm/i915: add register macro definition style guide

2017-08-08 Thread Jani Nikula
On Mon, 07 Aug 2017, Rodrigo Vivi wrote: > good idea. > > > On Mon, Aug 7, 2017 at 9:10 AM, Daniel Vetter wrote: >> On Fri, Aug 04, 2017 at 01:38:36PM +0300, Jani Nikula wrote: >> >>> + * >>> + * For bit fields, define a _MASK and a _SHIFT macro. Define

Re: [Intel-gfx] [PATCH] drm/i915: add register macro definition style guide

2017-08-08 Thread Jani Nikula
On Mon, 07 Aug 2017, Daniel Vetter wrote: > On Fri, Aug 04, 2017 at 01:38:36PM +0300, Jani Nikula wrote: >> This is not to try to force a new style; this is my interpretation of >> what the most common existing style is. >> >> With hopes I don't need to answer so many questions

Re: [Intel-gfx] [PATCH] drm/i915: add register macro definition style guide

2017-08-07 Thread Rodrigo Vivi
good idea. On Mon, Aug 7, 2017 at 9:10 AM, Daniel Vetter wrote: > On Fri, Aug 04, 2017 at 01:38:36PM +0300, Jani Nikula wrote: >> This is not to try to force a new style; this is my interpretation of >> what the most common existing style is. >> >> With hopes I don't need to

Re: [Intel-gfx] [PATCH] drm/i915: add register macro definition style guide

2017-08-07 Thread Daniel Vetter
On Fri, Aug 04, 2017 at 01:38:36PM +0300, Jani Nikula wrote: > This is not to try to force a new style; this is my interpretation of > what the most common existing style is. > > With hopes I don't need to answer so many questions about style going > forward. > > Cc: Daniel Vetter

[Intel-gfx] [PATCH] drm/i915: add register macro definition style guide

2017-08-04 Thread Jani Nikula
This is not to try to force a new style; this is my interpretation of what the most common existing style is. With hopes I don't need to answer so many questions about style going forward. Cc: Daniel Vetter Signed-off-by: Jani Nikula --- N.b.