[Intel-gfx] [PATCH] drm/i915: debug sink dpms aux errors also on enable

[Jani Nikula]

Signed-off-by: Jani Nikula jani.nik...@intel.com
---
 drivers/gpu/drm/i915/intel_dp.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index d7fc2c0e9ba8..f112d7d2f8bd 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1553,8 +1553,6 @@ void intel_dp_sink_dpms(struct intel_dp *intel_dp, int 
mode)
if (mode != DRM_MODE_DPMS_ON) {
ret = drm_dp_dpcd_writeb(intel_dp-aux, DP_SET_POWER,
 DP_SET_POWER_D3);
-   if (ret != 1)
-   DRM_DEBUG_DRIVER(failed to write sink power state\n);
} else {
/*
 * When turning on, we need to retry for 1ms to give the sink
@@ -1568,6 +1566,10 @@ void intel_dp_sink_dpms(struct intel_dp *intel_dp, int 
mode)
msleep(1);
}
}
+
+   if (ret != 1)
+   DRM_DEBUG_KMS(failed to %s sink power state\n,
+ mode == DRM_MODE_DPMS_ON ? enable : disable);
 }
 
 static bool intel_dp_get_hw_state(struct intel_encoder *encoder,
-- 
1.9.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: debug sink dpms aux errors also on enable

[Daniel Vetter]

On Tue, Sep 02, 2014 at 04:33:52PM +0300, Jani Nikula wrote:
 Signed-off-by: Jani Nikula jani.nik...@intel.com

Queued for -next, thanks for the patch.
-Daniel

 ---
  drivers/gpu/drm/i915/intel_dp.c | 6 --
  1 file changed, 4 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
 index d7fc2c0e9ba8..f112d7d2f8bd 100644
 --- a/drivers/gpu/drm/i915/intel_dp.c
 +++ b/drivers/gpu/drm/i915/intel_dp.c
 @@ -1553,8 +1553,6 @@ void intel_dp_sink_dpms(struct intel_dp *intel_dp, int 
 mode)
   if (mode != DRM_MODE_DPMS_ON) {
   ret = drm_dp_dpcd_writeb(intel_dp-aux, DP_SET_POWER,
DP_SET_POWER_D3);
 - if (ret != 1)
 - DRM_DEBUG_DRIVER(failed to write sink power state\n);
   } else {
   /*
* When turning on, we need to retry for 1ms to give the sink
 @@ -1568,6 +1566,10 @@ void intel_dp_sink_dpms(struct intel_dp *intel_dp, int 
 mode)
   msleep(1);
   }
   }
 +
 + if (ret != 1)
 + DRM_DEBUG_KMS(failed to %s sink power state\n,
 +   mode == DRM_MODE_DPMS_ON ? enable : disable);
  }
  
  static bool intel_dp_get_hw_state(struct intel_encoder *encoder,
 -- 
 1.9.1
 
 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx