Re: [Intel-gfx] [PATCH] drm/i915: encourage BIT() macro usage in register definitions

2018-06-28 Thread Rodrigo Vivi
On Thu, Jun 28, 2018 at 10:45:02AM -0700, Paulo Zanoni wrote: > Em Qui, 2018-06-28 às 15:03 +0300, Jani Nikula escreveu: > > On Wed, 27 Jun 2018, Chris Wilson wrote: > > > Quoting Michal Wajdeczko (2018-06-27 16:51:42) > > > > On Wed, 27 Jun 2018 16:41:13 +0200, Jani Nikula > > > l.com> > > >

Re: [Intel-gfx] [PATCH] drm/i915: encourage BIT() macro usage in register definitions

2018-06-28 Thread Paulo Zanoni
Em Qui, 2018-06-28 às 15:03 +0300, Jani Nikula escreveu: > On Wed, 27 Jun 2018, Chris Wilson wrote: > > Quoting Michal Wajdeczko (2018-06-27 16:51:42) > > > On Wed, 27 Jun 2018 16:41:13 +0200, Jani Nikula > > l.com> > > > wrote: > > > > > > > There's already some BIT() usage here and there,

Re: [Intel-gfx] [PATCH] drm/i915: encourage BIT() macro usage in register definitions

2018-06-28 Thread Jani Nikula
On Wed, 27 Jun 2018, Chris Wilson wrote: > Quoting Michal Wajdeczko (2018-06-27 16:51:42) >> On Wed, 27 Jun 2018 16:41:13 +0200, Jani Nikula >> wrote: >> >> > There's already some BIT() usage here and there, embrace it. >> > >> > Cc: Paulo Zanoni >> > Signed-off-by: Jani Nikula >> > --- >>

Re: [Intel-gfx] [PATCH] drm/i915: encourage BIT() macro usage in register definitions

2018-06-27 Thread Rodrigo Vivi
On Wed, Jun 27, 2018 at 05:41:13PM +0300, Jani Nikula wrote: > There's already some BIT() usage here and there, embrace it. > > Cc: Paulo Zanoni > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_reg.h | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH] drm/i915: encourage BIT() macro usage in register definitions

2018-06-27 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-06-27 16:51:42) > On Wed, 27 Jun 2018 16:41:13 +0200, Jani Nikula > wrote: > > > There's already some BIT() usage here and there, embrace it. > > > > Cc: Paulo Zanoni > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/i915/i915_reg.h | 9 + > >

Re: [Intel-gfx] [PATCH] drm/i915: encourage BIT() macro usage in register definitions

2018-06-27 Thread Michal Wajdeczko
On Wed, 27 Jun 2018 16:41:13 +0200, Jani Nikula wrote: There's already some BIT() usage here and there, embrace it. Cc: Paulo Zanoni Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915: encourage BIT() macro usage in register definitions

2018-06-27 Thread Jani Nikula
There's already some BIT() usage here and there, embrace it. Cc: Paulo Zanoni Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index