Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

2016-10-25 Thread Chris Wilson
On Tue, Oct 25, 2016 at 12:29:41PM +0100, Matthew Auld wrote: > > These are untraced mmio-accessors that are only valid to be used inside > > critical sections inside IRQ handlers where forcewake is explicitly > > controlled. > > > > Think twice, and think again, before using these. > > > > Those

Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

2016-10-25 Thread Matthew Auld
> These are untraced mmio-accessors that are only valid to be used inside > critical sections inside IRQ handlers where forcewake is explicitly > controlled. > > Think twice, and think again, before using these. > > Those possibly should be used between: > > spin_lock_irq(_priv->uncore.lock); >

Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

2016-10-24 Thread Arkadiusz Hiler
On Fri, Oct 21, 2016 at 02:57:28PM +0100, Chris Wilson wrote: > On Fri, Oct 21, 2016 at 04:00:10PM +0300, Mika Kuoppala wrote: > > Chris Wilson writes: > > > > > On Fri, Oct 21, 2016 at 02:16:46PM +0200, Arkadiusz Hiler wrote: > > >> On Wed, Aug 24, 2016 at 05:03:11PM

Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

2016-10-21 Thread Chris Wilson
On Fri, Oct 21, 2016 at 04:00:10PM +0300, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Fri, Oct 21, 2016 at 02:16:46PM +0200, Arkadiusz Hiler wrote: > >> On Wed, Aug 24, 2016 at 05:03:11PM +0100, Matthew Auld wrote: > >> > The comment which documents the proper

Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

2016-10-21 Thread Mika Kuoppala
Chris Wilson writes: > On Fri, Oct 21, 2016 at 02:16:46PM +0200, Arkadiusz Hiler wrote: >> On Wed, Aug 24, 2016 at 05:03:11PM +0100, Matthew Auld wrote: >> > The comment which documents the proper usage of the *_FW family of macros >> > makes >> > reference to

Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

2016-10-21 Thread Chris Wilson
On Fri, Oct 21, 2016 at 02:16:46PM +0200, Arkadiusz Hiler wrote: > On Wed, Aug 24, 2016 at 05:03:11PM +0100, Matthew Auld wrote: > > The comment which documents the proper usage of the *_FW family of macros > > makes > > reference to intel_uncore_forcewake_irq{unlock, lock}, which is just > >

Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

2016-10-21 Thread Arkadiusz Hiler
On Wed, Aug 24, 2016 at 05:03:11PM +0100, Matthew Auld wrote: > The comment which documents the proper usage of the *_FW family of macros > makes > reference to intel_uncore_forcewake_irq{unlock, lock}, which is just > confusing, seeing as such a set of functions don't even exist and never have >

[Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

2016-08-24 Thread Matthew Auld
The comment which documents the proper usage of the *_FW family of macros makes reference to intel_uncore_forcewake_irq{unlock, lock}, which is just confusing, seeing as such a set of functions don't even exist and never have for that matter(according to git). Let's fix that by replacing them with