Re: [Intel-gfx] [PATCH] drm/vblank: Document and fix vblank count barrier semantics

2019-09-03 Thread Daniel Vetter
On Tue, Sep 03, 2019 at 11:17:12AM -0400, Rodrigo Siqueira wrote: > Hi, thanks for the explanation. > > I noticed that I forgot to add my r-b. > > Reviewed-by: Rodrigo Siqueira Uh I just pushed, so can't add your r-b now :-/ Sry. -Daniel > > On 09/03, Daniel Vetter wrote: > > On Tue, Sep

Re: [Intel-gfx] [PATCH] drm/vblank: Document and fix vblank count barrier semantics

2019-09-03 Thread Rodrigo Siqueira
Hi, thanks for the explanation. I noticed that I forgot to add my r-b. Reviewed-by: Rodrigo Siqueira On 09/03, Daniel Vetter wrote: > On Tue, Sep 03, 2019 at 08:47:03AM -0400, Rodrigo Siqueira wrote: > > Hi Daniel, > > > > All the series look really good for me. I just have some few questions

Re: [Intel-gfx] [PATCH] drm/vblank: Document and fix vblank count barrier semantics

2019-09-03 Thread Daniel Vetter
On Tue, Sep 03, 2019 at 08:47:03AM -0400, Rodrigo Siqueira wrote: > Hi Daniel, > > All the series look really good for me. I just have some few questions > here. > > On 07/23, Daniel Vetter wrote: > > Noticed while reviewing code. I'm not sure whether this might or might > > not explain some of

Re: [Intel-gfx] [PATCH] drm/vblank: Document and fix vblank count barrier semantics

2019-09-03 Thread Rodrigo Siqueira
Hi Daniel, All the series look really good for me. I just have some few questions here. On 07/23, Daniel Vetter wrote: > Noticed while reviewing code. I'm not sure whether this might or might > not explain some of the missed vblank hilarity we've been seeing. I I have to admit that I'm a little

Re: [Intel-gfx] [PATCH] drm/vblank: Document and fix vblank count barrier semantics

2019-08-19 Thread Ville Syrjälä
On Tue, Jul 23, 2019 at 03:13:37PM +0200, Daniel Vetter wrote: > Noticed while reviewing code. I'm not sure whether this might or might > not explain some of the missed vblank hilarity we've been seeing. I > think those all go through the vblank completion event, which has > unconditional barriers

[Intel-gfx] [PATCH] drm/vblank: Document and fix vblank count barrier semantics

2019-07-23 Thread Daniel Vetter
Noticed while reviewing code. I'm not sure whether this might or might not explain some of the missed vblank hilarity we've been seeing. I think those all go through the vblank completion event, which has unconditional barriers - it always takes the spinlock. Therefore no cc stable. v2: -