Re: [Intel-gfx] [PATCH] drm: Fix uabi regression by allowing garbage mode->type from userspace

2018-03-23 Thread Ville Syrjälä
On Thu, Mar 22, 2018 at 08:42:11AM +0100, Thomas Hellstrom wrote: > On 03/21/2018 10:12 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Apparently xf86-video-vmware leaves the mode->type uninitialized > > when feeding the mode to the kernel. Thus we have no

Re: [Intel-gfx] [PATCH] drm: Fix uabi regression by allowing garbage mode->type from userspace

2018-03-23 Thread Daniel Stone
On 21 March 2018 at 21:12, Ville Syrjala wrote: > Apparently xf86-video-vmware leaves the mode->type uninitialized > when feeding the mode to the kernel. Thus we have no choice but > to accept the garbage in. We'll just ignore any of the bits we > don't want. The

Re: [Intel-gfx] [PATCH] drm: Fix uabi regression by allowing garbage mode->type from userspace

2018-03-23 Thread Maarten Lankhorst
Op 22-03-18 om 08:42 schreef Thomas Hellstrom: > On 03/21/2018 10:12 PM, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Apparently xf86-video-vmware leaves the mode->type uninitialized >> when feeding the mode to the kernel. Thus we have no choice but >> to

Re: [Intel-gfx] [PATCH] drm: Fix uabi regression by allowing garbage mode->type from userspace

2018-03-22 Thread Thomas Hellstrom
On 03/21/2018 10:12 PM, Ville Syrjala wrote: From: Ville Syrjälä Apparently xf86-video-vmware leaves the mode->type uninitialized when feeding the mode to the kernel. Thus we have no choice but to accept the garbage in. We'll just ignore any of the bits we don't

[Intel-gfx] [PATCH] drm: Fix uabi regression by allowing garbage mode->type from userspace

2018-03-21 Thread Ville Syrjala
From: Ville Syrjälä Apparently xf86-video-vmware leaves the mode->type uninitialized when feeding the mode to the kernel. Thus we have no choice but to accept the garbage in. We'll just ignore any of the bits we don't want. The mode type is just a hint anyway, and