Re: [Intel-gfx] [PATCH] drm: Reorder set_property_atomic to avoid returning with an active ww_ctx

2019-01-07 Thread Daniel Vetter
On Thu, Jan 03, 2019 at 10:16:54AM +, Chris Wilson wrote: > Quoting Maarten Lankhorst (2019-01-03 09:03:27) > > Op 30-12-2018 om 13:28 schreef Chris Wilson: > > > Delay the drm_modeset_acquire_init() until after we check for an > > > allocation failure so that we can return immediately upon

Re: [Intel-gfx] [PATCH] drm: Reorder set_property_atomic to avoid returning with an active ww_ctx

2019-01-03 Thread Chris Wilson
Quoting Maarten Lankhorst (2019-01-03 09:03:27) > Op 30-12-2018 om 13:28 schreef Chris Wilson: > > Delay the drm_modeset_acquire_init() until after we check for an > > allocation failure so that we can return immediately upon error without > > having to unwind. > > > > WARNING: lock held when

Re: [Intel-gfx] [PATCH] drm: Reorder set_property_atomic to avoid returning with an active ww_ctx

2019-01-03 Thread Maarten Lankhorst
Op 30-12-2018 om 13:28 schreef Chris Wilson: > Delay the drm_modeset_acquire_init() until after we check for an > allocation failure so that we can return immediately upon error without > having to unwind. > > WARNING: lock held when returning to user space! > 4.20.0+ #174 Not tainted >

[Intel-gfx] [PATCH] drm: Reorder set_property_atomic to avoid returning with an active ww_ctx

2018-12-30 Thread Chris Wilson
Delay the drm_modeset_acquire_init() until after we check for an allocation failure so that we can return immediately upon error without having to unwind. WARNING: lock held when returning to user space! 4.20.0+ #174 Not tainted