Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-12-01 Thread Dave Young
On 12/01/16 at 04:00pm, Dave Young wrote: > On 11/30/16 at 03:25pm, Ville Syrjälä wrote: > > On Thu, Nov 24, 2016 at 05:03:20PM +0800, Dave Young wrote: > > > On 11/24/16 at 10:53am, Jani Nikula wrote: > > > > On Thu, 24 Nov 2016, Dave Young wrote: > > > > > I see a lot of

Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-12-01 Thread Dave Young
On 11/30/16 at 03:25pm, Ville Syrjälä wrote: > On Thu, Nov 24, 2016 at 05:03:20PM +0800, Dave Young wrote: > > On 11/24/16 at 10:53am, Jani Nikula wrote: > > > On Thu, 24 Nov 2016, Dave Young wrote: > > > > I see a lot of below warning: > > > > > > No, we must not hide this

Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-11-30 Thread Ville Syrjälä
On Thu, Nov 24, 2016 at 05:03:20PM +0800, Dave Young wrote: > On 11/24/16 at 10:53am, Jani Nikula wrote: > > On Thu, 24 Nov 2016, Dave Young wrote: > > > I see a lot of below warning: > > > > No, we must not hide this under the carpet. There's a bug at fdo about > > this, and

Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-11-24 Thread Dave Young
On 11/24/16 at 10:53am, Jani Nikula wrote: > On Thu, 24 Nov 2016, Dave Young wrote: > > I see a lot of below warning: > > No, we must not hide this under the carpet. There's a bug at fdo about > this, and we need to fix it. It is not hiding it, just not repeating the

Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-11-24 Thread Jani Nikula
On Thu, 24 Nov 2016, Dave Young wrote: > I see a lot of below warning: No, we must not hide this under the carpet. There's a bug at fdo about this, and we need to fix it. BR, Jani. > [ 17.128256] WARNING: CPU: 1 PID: 95 at > drivers/gpu/drm/i915/intel_dp.c:1062

[Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-11-24 Thread Dave Young
I see a lot of below warning: [ 17.128256] WARNING: CPU: 1 PID: 95 at drivers/gpu/drm/i915/intel_dp.c:1062 intel_dp_aux_transfer+0x201/0x240 [i915] [ 17.128264] WARN_ON_ONCE(!msg->buffer != !msg->size) [ 17.128267] Modules linked in: [ 17.128273] kvm_intel kvm irqbypass i915 intel_gtt