Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-11 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
 On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
  Patch drm/i915: Make the physical object coherent with GTT - Reviewer:
 
 Already has my r-b.

I still would like to see a little testcase here, e.g. a new mode to
kms_cursor_crc which uses gtt mmap uploads instead of pwrite.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-11 Thread Chris Wilson
On Tue, Nov 11, 2014 at 11:20:14AM +0100, Daniel Vetter wrote:
 On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
  On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
   Patch drm/i915: Make the physical object coherent with GTT - Reviewer:
  
  Already has my r-b.
 
 I still would like to see a little testcase here, e.g. a new mode to
 kms_cursor_crc which uses gtt mmap uploads instead of pwrite.

But that doesn't block this patch, as the kernel already exposes and
userspace already uses gtt mmap updates to the cursor. The patch just
removes the barrier to do so using early chipsets as well.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-11 Thread Daniel Vetter
On Tue, Nov 11, 2014 at 10:22:11AM +, Chris Wilson wrote:
 On Tue, Nov 11, 2014 at 11:20:14AM +0100, Daniel Vetter wrote:
  On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
   On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
Patch drm/i915: Make the physical object coherent with GTT - 
Reviewer:
   
   Already has my r-b.
  
  I still would like to see a little testcase here, e.g. a new mode to
  kms_cursor_crc which uses gtt mmap uploads instead of pwrite.
 
 But that doesn't block this patch, as the kernel already exposes and
 userspace already uses gtt mmap updates to the cursor. The patch just
 removes the barrier to do so using early chipsets as well.

Well yeah, but that existing code has piles of tests already to make sure
that gtt writes are somewhat coherent with pwrite, and another test that
pwrite is coherent with the actual cursor scanned out by hw.

This otoh adds new code, without igt test coverage. So there is a new test
coverage gap.

Anyway I've decided that the cleanup is worth it on its own and the
platform this applies to are too old to really care, so merged the patch
without tests.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-11 Thread Chris Wilson
On Tue, Nov 11, 2014 at 12:54:13PM +0100, Daniel Vetter wrote:
 On Tue, Nov 11, 2014 at 10:22:11AM +, Chris Wilson wrote:
  On Tue, Nov 11, 2014 at 11:20:14AM +0100, Daniel Vetter wrote:
   On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
 Patch drm/i915: Make the physical object coherent with GTT - 
 Reviewer:

Already has my r-b.
   
   I still would like to see a little testcase here, e.g. a new mode to
   kms_cursor_crc which uses gtt mmap uploads instead of pwrite.
  
  But that doesn't block this patch, as the kernel already exposes and
  userspace already uses gtt mmap updates to the cursor. The patch just
  removes the barrier to do so using early chipsets as well.
 
 Well yeah, but that existing code has piles of tests already to make sure
 that gtt writes are somewhat coherent with pwrite, and another test that
 pwrite is coherent with the actual cursor scanned out by hw.

Really? I doubt the current coverage since I keep seeing cursor bugs...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-11 Thread Ville Syrjälä
On Tue, Nov 11, 2014 at 12:54:13PM +0100, Daniel Vetter wrote:
 On Tue, Nov 11, 2014 at 10:22:11AM +, Chris Wilson wrote:
  On Tue, Nov 11, 2014 at 11:20:14AM +0100, Daniel Vetter wrote:
   On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
 Patch drm/i915: Make the physical object coherent with GTT - 
 Reviewer:

Already has my r-b.
   
   I still would like to see a little testcase here, e.g. a new mode to
   kms_cursor_crc which uses gtt mmap uploads instead of pwrite.
  
  But that doesn't block this patch, as the kernel already exposes and
  userspace already uses gtt mmap updates to the cursor. The patch just
  removes the barrier to do so using early chipsets as well.
 
 Well yeah, but that existing code has piles of tests already to make sure
 that gtt writes are somewhat coherent with pwrite, and another test that
 pwrite is coherent with the actual cursor scanned out by hw.

Actually pwrite isn't coherent with scanout currently on LLC platforms
if you do the pwrite when the bo already has cache_level==NONE but it's
not yet pinned to the display. So seems our pwrite tests aren't entirely
comprehensive currently if they don't hit this. I still haven't seen
the fabled patch from Chris that would fix this.

 
 This otoh adds new code, without igt test coverage. So there is a new test
 coverage gap.
 
 Anyway I've decided that the cleanup is worth it on its own and the
 platform this applies to are too old to really care, so merged the patch
 without tests.
 -Daniel
 -- 
 Daniel Vetter
 Software Engineer, Intel Corporation
 +41 (0) 79 365 57 48 - http://blog.ffwll.ch

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-11 Thread Chris Wilson
On Tue, Nov 11, 2014 at 02:16:32PM +0200, Ville Syrjälä wrote:
 On Tue, Nov 11, 2014 at 12:54:13PM +0100, Daniel Vetter wrote:
  On Tue, Nov 11, 2014 at 10:22:11AM +, Chris Wilson wrote:
   On Tue, Nov 11, 2014 at 11:20:14AM +0100, Daniel Vetter wrote:
On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
 On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
  Patch drm/i915: Make the physical object coherent with GTT - 
  Reviewer:
 
 Already has my r-b.

I still would like to see a little testcase here, e.g. a new mode to
kms_cursor_crc which uses gtt mmap uploads instead of pwrite.
   
   But that doesn't block this patch, as the kernel already exposes and
   userspace already uses gtt mmap updates to the cursor. The patch just
   removes the barrier to do so using early chipsets as well.
  
  Well yeah, but that existing code has piles of tests already to make sure
  that gtt writes are somewhat coherent with pwrite, and another test that
  pwrite is coherent with the actual cursor scanned out by hw.
 
 Actually pwrite isn't coherent with scanout currently on LLC platforms
 if you do the pwrite when the bo already has cache_level==NONE but it's
 not yet pinned to the display. So seems our pwrite tests aren't entirely
 comprehensive currently if they don't hit this. I still haven't seen
 the fabled patch from Chris that would fix this.

This patch includes an unconditional clflush for phys writes (or at
least this patch should be that patch) which is what I thought we were
arguing about at the time.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-11 Thread Ville Syrjälä
On Tue, Nov 11, 2014 at 12:26:59PM +, Chris Wilson wrote:
 On Tue, Nov 11, 2014 at 02:16:32PM +0200, Ville Syrjälä wrote:
  On Tue, Nov 11, 2014 at 12:54:13PM +0100, Daniel Vetter wrote:
   On Tue, Nov 11, 2014 at 10:22:11AM +, Chris Wilson wrote:
On Tue, Nov 11, 2014 at 11:20:14AM +0100, Daniel Vetter wrote:
 On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
  On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
   Patch drm/i915: Make the physical object coherent with GTT - 
   Reviewer:
  
  Already has my r-b.
 
 I still would like to see a little testcase here, e.g. a new mode to
 kms_cursor_crc which uses gtt mmap uploads instead of pwrite.

But that doesn't block this patch, as the kernel already exposes and
userspace already uses gtt mmap updates to the cursor. The patch just
removes the barrier to do so using early chipsets as well.
   
   Well yeah, but that existing code has piles of tests already to make sure
   that gtt writes are somewhat coherent with pwrite, and another test that
   pwrite is coherent with the actual cursor scanned out by hw.
  
  Actually pwrite isn't coherent with scanout currently on LLC platforms
  if you do the pwrite when the bo already has cache_level==NONE but it's
  not yet pinned to the display. So seems our pwrite tests aren't entirely
  comprehensive currently if they don't hit this. I still haven't seen
  the fabled patch from Chris that would fix this.
 
 This patch includes an unconditional clflush for phys writes (or at
 least this patch should be that patch) which is what I thought we were
 arguing about at the time.

Ah, so there's no patch then? I must have misundestood. I do remember you
had a quick hack to always flush in set_cache_level(), but I guess it
never went beyond that.

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-11 Thread Chris Wilson
On Tue, Nov 11, 2014 at 02:38:15PM +0200, Ville Syrjälä wrote:
 On Tue, Nov 11, 2014 at 12:26:59PM +, Chris Wilson wrote:
  This patch includes an unconditional clflush for phys writes (or at
  least this patch should be that patch) which is what I thought we were
  arguing about at the time.
 
 Ah, so there's no patch then? I must have misundestood. I do remember you
 had a quick hack to always flush in set_cache_level(), but I guess it
 never went beyond that.

I have nothing in my tree. The last I remember on that subject was the
obj-pin_display forcing the clflush.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-11 Thread Daniel Vetter
On Tue, Nov 11, 2014 at 11:57:16AM +, Chris Wilson wrote:
 On Tue, Nov 11, 2014 at 12:54:13PM +0100, Daniel Vetter wrote:
  On Tue, Nov 11, 2014 at 10:22:11AM +, Chris Wilson wrote:
   On Tue, Nov 11, 2014 at 11:20:14AM +0100, Daniel Vetter wrote:
On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
 On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
  Patch drm/i915: Make the physical object coherent with GTT - 
  Reviewer:
 
 Already has my r-b.

I still would like to see a little testcase here, e.g. a new mode to
kms_cursor_crc which uses gtt mmap uploads instead of pwrite.
   
   But that doesn't block this patch, as the kernel already exposes and
   userspace already uses gtt mmap updates to the cursor. The patch just
   removes the barrier to do so using early chipsets as well.
  
  Well yeah, but that existing code has piles of tests already to make sure
  that gtt writes are somewhat coherent with pwrite, and another test that
  pwrite is coherent with the actual cursor scanned out by hw.
 
 Really? I doubt the current coverage since I keep seeing cursor bugs...

Well they do tend to randomly fail here. Not sure whether that's the same
bug or a different one ... Ofc tests without people looking aren't too
useful, but we have to start somewhere.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-11 Thread Daniel Vetter
On Tue, Nov 11, 2014 at 02:16:32PM +0200, Ville Syrjälä wrote:
 On Tue, Nov 11, 2014 at 12:54:13PM +0100, Daniel Vetter wrote:
  On Tue, Nov 11, 2014 at 10:22:11AM +, Chris Wilson wrote:
   On Tue, Nov 11, 2014 at 11:20:14AM +0100, Daniel Vetter wrote:
On Thu, Nov 06, 2014 at 09:57:29AM +0200, Ville Syrjälä wrote:
 On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
  Patch drm/i915: Make the physical object coherent with GTT - 
  Reviewer:
 
 Already has my r-b.

I still would like to see a little testcase here, e.g. a new mode to
kms_cursor_crc which uses gtt mmap uploads instead of pwrite.
   
   But that doesn't block this patch, as the kernel already exposes and
   userspace already uses gtt mmap updates to the cursor. The patch just
   removes the barrier to do so using early chipsets as well.
  
  Well yeah, but that existing code has piles of tests already to make sure
  that gtt writes are somewhat coherent with pwrite, and another test that
  pwrite is coherent with the actual cursor scanned out by hw.
 
 Actually pwrite isn't coherent with scanout currently on LLC platforms
 if you do the pwrite when the bo already has cache_level==NONE but it's
 not yet pinned to the display. So seems our pwrite tests aren't entirely
 comprehensive currently if they don't hit this. I still haven't seen
 the fabled patch from Chris that would fix this.

Yeah they don't check the display using CRCs for all corner cases, that
seems to indeed be missing. But should be fairly simple to add a new
subtest to kms_cursor_crc to rotate the color quadrants a bit with pwrite
for each frame.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-05 Thread Rodrigo Vivi
Just a warning that this round collector had many differences on PRTS:

HSw:
Testing: http://tinderbox.sh.intel.com/PRTS_UI/prtsresult.php?task_id=3869
Collector: http://tinderbox.sh.intel.com/PRTS_UI/prtsresult.php?task_id=3874
Comparison: 
http://tinderbox.sh.intel.com/PRTS_UI/prtscompareresult.php?sub_task_id1=15868sub_task_id2=15873

ILK:
Testing: http://tinderbox.sh.intel.com/PRTS_UI/prtsresult.php?task_id=3872
Collector: http://tinderbox.sh.intel.com/PRTS_UI/prtsresult.php?task_id=3870
Comparison: 
http://tinderbox.sh.intel.com/PRTS_UI/prtscompareresult.php?sub_task_id1=15871sub_task_id2=15869

IVB:
Testing: http://tinderbox.sh.intel.com/PRTS_UI/prtsresult.php?task_id=3871
Collector: http://tinderbox.sh.intel.com/PRTS_UI/prtsresult.php?task_id=3873
Comparison: 
http://tinderbox.sh.intel.com/PRTS_UI/prtscompareresult.php?sub_task_id1=15870sub_task_id2=15872

Most of differences related to kms_flip and kms_plane, gem_evic and
gem_concurrent. And most breaking more stuff than fixing them.


On Tue, Nov 4, 2014 at 4:51 AM, Rodrigo Vivi rodrigo.v...@intel.com wrote:

 This is another drm-intel-collector updated notice:
 http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector

 Here goes the update list in order for better reviewers assignment:

 Patch drm/i915: Check the minimum pitch for the user framebuffer - 
 Reviewer:
 Patch drm/i915: Make the physical object coherent with GTT - Reviewer:
 Patch drm/i915/chv: Use timeout mode for RC6 on chv - Reviewer:
 Patch drm/i915: Specify bsd rings through exec flag - Reviewer:
 Patch drm/i915: add I915_PARAM_HAS_BSD2 to i915_getparam - Reviewer:
 Patch drm/i915: Enable vblank interrupts for CRC generation - Reviewer:
 Patch drm/i915: Move the ban period onto the context - Reviewer:
 Patch drm/i915: Add ioctl to set per-context parameters - Reviewer:
 Patch drm/i915: Put logical pipe_control emission into a helper. - 
 Reviewer:
 Patch drm/i915: Add WaCsStallBeforeStateCacheInvalidate:bdw, chv to 
 logical ring - Reviewer:


 This update refers to five rounds between testing updates:
 - Jul 25 to Aug 08
 - Aug 08 to Aug 22
 - Aug 22 to Sep 09
 - Sep 09 to Sep 19
 - Sep 19 to Oct 03

 As always I just get standalone patches or series of 2 patches that had no 
 obvious nacks or unfinished discussion.
 If you thinkg your patch should be here please let me know or rebase over 
 -nightly and resubmit that I collect
 later.

 Thanks,
 Rodrigo.


 Chris Wilson (5):
   drm/i915: Check the minimum pitch for the user framebuffer
   drm/i915: Make the physical object coherent with GTT
   drm/i915: Enable vblank interrupts for CRC generation
   drm/i915: Move the ban period onto the context
   drm/i915: Add ioctl to set per-context parameters

 Deepak S (1):
   drm/i915/chv: Use timeout mode for RC6 on chv

 Rodrigo Vivi (2):
   drm/i915: Put logical pipe_control emission into a helper.
   drm/i915: Add WaCsStallBeforeStateCacheInvalidate:bdw, chv to logical
 ring

 Zhipeng Gong (2):
   drm/i915: Specify bsd rings through exec flag
   drm/i915: add I915_PARAM_HAS_BSD2 to i915_getparam

  drivers/gpu/drm/i915/i915_debugfs.c|   7 +
  drivers/gpu/drm/i915/i915_dma.c|   8 ++
  drivers/gpu/drm/i915/i915_drv.h|  15 ++-
  drivers/gpu/drm/i915/i915_gem.c| 210 
 -
  drivers/gpu/drm/i915/i915_gem_context.c|  71 ++
  drivers/gpu/drm/i915/i915_gem_execbuffer.c |  19 ++-
  drivers/gpu/drm/i915/intel_display.c   |  11 ++
  drivers/gpu/drm/i915/intel_dp.c|   3 +
  drivers/gpu/drm/i915/intel_lrc.c   |  41 --
  drivers/gpu/drm/i915/intel_pm.c|   4 +-
  include/uapi/drm/i915_drm.h|  22 ++-
  11 files changed, 326 insertions(+), 85 deletions(-)

 --
 1.9.3

 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-05 Thread Ville Syrjälä
On Tue, Nov 04, 2014 at 04:51:38AM -0800, Rodrigo Vivi wrote:
 
 This is another drm-intel-collector updated notice:
 http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector
 
 Here goes the update list in order for better reviewers assignment:
 
 Patch drm/i915: Check the minimum pitch for the user framebuffer - 
 Reviewer:

My comment still stands that the core checks should have caught this.
Actually now I think about it, addfb didn't call framebuffer_check()
until very recently, which could explain this. So the problem might be
fixed by

commit 228f2cb32f0dbeef0b88dc97ea66a3c31b03de99
Author: Chuck Ebbert cebbert.l...@gmail.com
Date:   Wed Oct 8 11:40:34 2014 -0500

drm/crtc: Remove duplicated ioctl code

 Patch drm/i915: Make the physical object coherent with GTT - Reviewer:

Already has my r-b.

 Patch drm/i915: Enable vblank interrupts for CRC generation - Reviewer:

IIRC everyone agreed that this isn't needed.

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-11-04 Thread Rodrigo Vivi

This is another drm-intel-collector updated notice:
http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector

Here goes the update list in order for better reviewers assignment:

Patch drm/i915: Check the minimum pitch for the user framebuffer - Reviewer:
Patch drm/i915: Make the physical object coherent with GTT - Reviewer:
Patch drm/i915/chv: Use timeout mode for RC6 on chv - Reviewer:
Patch drm/i915: Specify bsd rings through exec flag - Reviewer:
Patch drm/i915: add I915_PARAM_HAS_BSD2 to i915_getparam - Reviewer:
Patch drm/i915: Enable vblank interrupts for CRC generation - Reviewer:
Patch drm/i915: Move the ban period onto the context - Reviewer:
Patch drm/i915: Add ioctl to set per-context parameters - Reviewer:
Patch drm/i915: Put logical pipe_control emission into a helper. - Reviewer:
Patch drm/i915: Add WaCsStallBeforeStateCacheInvalidate:bdw, chv to logical 
ring - Reviewer:


This update refers to five rounds between testing updates:
- Jul 25 to Aug 08
- Aug 08 to Aug 22
- Aug 22 to Sep 09
- Sep 09 to Sep 19
- Sep 19 to Oct 03

As always I just get standalone patches or series of 2 patches that had no 
obvious nacks or unfinished discussion.
If you thinkg your patch should be here please let me know or rebase over 
-nightly and resubmit that I collect
later.

Thanks,
Rodrigo.


Chris Wilson (5):
  drm/i915: Check the minimum pitch for the user framebuffer
  drm/i915: Make the physical object coherent with GTT
  drm/i915: Enable vblank interrupts for CRC generation
  drm/i915: Move the ban period onto the context
  drm/i915: Add ioctl to set per-context parameters

Deepak S (1):
  drm/i915/chv: Use timeout mode for RC6 on chv

Rodrigo Vivi (2):
  drm/i915: Put logical pipe_control emission into a helper.
  drm/i915: Add WaCsStallBeforeStateCacheInvalidate:bdw, chv to logical
ring

Zhipeng Gong (2):
  drm/i915: Specify bsd rings through exec flag
  drm/i915: add I915_PARAM_HAS_BSD2 to i915_getparam

 drivers/gpu/drm/i915/i915_debugfs.c|   7 +
 drivers/gpu/drm/i915/i915_dma.c|   8 ++
 drivers/gpu/drm/i915/i915_drv.h|  15 ++-
 drivers/gpu/drm/i915/i915_gem.c| 210 -
 drivers/gpu/drm/i915/i915_gem_context.c|  71 ++
 drivers/gpu/drm/i915/i915_gem_execbuffer.c |  19 ++-
 drivers/gpu/drm/i915/intel_display.c   |  11 ++
 drivers/gpu/drm/i915/intel_dp.c|   3 +
 drivers/gpu/drm/i915/intel_lrc.c   |  41 --
 drivers/gpu/drm/i915/intel_pm.c|   4 +-
 include/uapi/drm/i915_drm.h|  22 ++-
 11 files changed, 326 insertions(+), 85 deletions(-)

-- 
1.9.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-07-08 Thread Daniel Vetter
On Thu, Jul 03, 2014 at 05:32:56PM -0400, Rodrigo Vivi wrote:
 
 This is another drm-intel-collector updated notice:
 http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector
 
 It was 4 rounds out of date what made it hard to get old patches. However 
 Daniel and Jani didn't leave
 many patches behind.
 0 on Apr 4 - Apr 16
 1 on Apr 16 - May 6
 2 on May 6 - May 23
 3 on May 23 - Jun 6
 
 Next round Jun 6 to Jun 20 is only after next drm-intel-testing update.
 
 Here goes the update list in order for better reviewers assignment:
 
 Patch drm/i915: Bring UP Power Wells before disabling RC6. - Reviewer: 
 Paulo Zanoni paulo.r.zan...@intel.com - Reviewer:
 Patch drm/i915: Don't save/restore RS when not used - Reviewer:
 Patch drm/i915: Upgrade execbuffer fail after resume failure to EIO - 
 Reviewer:
 Patch drm/i915: Add property to set HDMI aspect ratio - Reviewer: Ville 
 Syrjälä ville.syrj...@linux.intel.com - Reviewer:
 Patch drm/i915/vlv: WA for Turbo and RC6 to work together. - Reviewer:
 Patch drm/i915: honour forced connector modes - Reviewer:
 Patch drm/i915: HWS must be in the mappable region for g33 - Reviewer:
 Patch drm/i915: Don't promote UC to WT automagically - Reviewer:

Not really sold on this patch from Ville ... I honestly can't think of a
use-case. Merged a few patches, and all the others look sane. Can you
please sign up a bunch of reviewers for this?

Thanks, Daniel

 Patch drm/i915/bdw: Always issue a force restore - Reviewer:
 Patch drm/i915/vlv: T12 eDP panel timing enforcement during reboot. - 
 Reviewer:
 
 
 There are some reasons that some patches can be left behind:
 1. Your patch didn't applied cleanly and I couldn't easily solve the 
 conflicts.
 2. Kernel didn't compiled with your patch.
 3. I simply missed it. If you believe this is the case please warn me.
 4. Remind that any reply to your email automatically take your patch to next 
 round.
 
 Please help me to get these patches reviewed and queued by Daniel.
 
 Thanks,
 Rodrigo.
 
 
 Ben Widawsky (2):
   drm/i915: Don't save/restore RS when not used
   drm/i915/bdw: Always issue a force restore
 
 Chris Wilson (3):
   drm/i915: Upgrade execbuffer fail after resume failure to EIO
   drm/i915: honour forced connector modes
   drm/i915: HWS must be in the mappable region for g33
 
 Clint Taylor (1):
   drm/i915/vlv: T12 eDP panel timing enforcement during reboot.
 
 Deepak S (2):
   drm/i915: Bring UP Power Wells before disabling RC6.
   drm/i915/vlv: WA for Turbo and RC6 to work together.
 
 Vandana Kannan (1):
   drm/i915: Add property to set HDMI aspect ratio
 
 Ville Syrjälä (1):
   drm/i915: Don't promote UC to WT automagically
 
  drivers/gpu/drm/i915/i915_drv.h|  16 
  drivers/gpu/drm/i915/i915_gem.c|   9 +-
  drivers/gpu/drm/i915/i915_gem_context.c|  15 ++--
  drivers/gpu/drm/i915/i915_gem_execbuffer.c |  15 +++-
  drivers/gpu/drm/i915/i915_irq.c| 133 
 -
  drivers/gpu/drm/i915/i915_reg.h|  11 +++
  drivers/gpu/drm/i915/intel_dp.c|  42 +
  drivers/gpu/drm/i915/intel_drv.h   |   4 +
  drivers/gpu/drm/i915/intel_fbdev.c |  33 +++
  drivers/gpu/drm/i915/intel_hdmi.c  |  12 +++
  drivers/gpu/drm/i915/intel_modes.c |  28 ++
  drivers/gpu/drm/i915/intel_pm.c|  18 +++-
  drivers/gpu/drm/i915/intel_ringbuffer.c|  16 +++-
  13 files changed, 318 insertions(+), 34 deletions(-)
 
 -- 
 1.9.0
 
 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-07-03 Thread Rodrigo Vivi

This is another drm-intel-collector updated notice:
http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector

It was 4 rounds out of date what made it hard to get old patches. However 
Daniel and Jani didn't leave
many patches behind.
0 on Apr 4 - Apr 16
1 on Apr 16 - May 6
2 on May 6 - May 23
3 on May 23 - Jun 6

Next round Jun 6 to Jun 20 is only after next drm-intel-testing update.

Here goes the update list in order for better reviewers assignment:

Patch drm/i915: Bring UP Power Wells before disabling RC6. - Reviewer: 
Paulo Zanoni paulo.r.zan...@intel.com - Reviewer:
Patch drm/i915: Don't save/restore RS when not used - Reviewer:
Patch drm/i915: Upgrade execbuffer fail after resume failure to EIO - 
Reviewer:
Patch drm/i915: Add property to set HDMI aspect ratio - Reviewer: Ville 
Syrjälä ville.syrj...@linux.intel.com - Reviewer:
Patch drm/i915/vlv: WA for Turbo and RC6 to work together. - Reviewer:
Patch drm/i915: honour forced connector modes - Reviewer:
Patch drm/i915: HWS must be in the mappable region for g33 - Reviewer:
Patch drm/i915: Don't promote UC to WT automagically - Reviewer:
Patch drm/i915/bdw: Always issue a force restore - Reviewer:
Patch drm/i915/vlv: T12 eDP panel timing enforcement during reboot. - 
Reviewer:


There are some reasons that some patches can be left behind:
1. Your patch didn't applied cleanly and I couldn't easily solve the conflicts.
2. Kernel didn't compiled with your patch.
3. I simply missed it. If you believe this is the case please warn me.
4. Remind that any reply to your email automatically take your patch to next 
round.

Please help me to get these patches reviewed and queued by Daniel.

Thanks,
Rodrigo.


Ben Widawsky (2):
  drm/i915: Don't save/restore RS when not used
  drm/i915/bdw: Always issue a force restore

Chris Wilson (3):
  drm/i915: Upgrade execbuffer fail after resume failure to EIO
  drm/i915: honour forced connector modes
  drm/i915: HWS must be in the mappable region for g33

Clint Taylor (1):
  drm/i915/vlv: T12 eDP panel timing enforcement during reboot.

Deepak S (2):
  drm/i915: Bring UP Power Wells before disabling RC6.
  drm/i915/vlv: WA for Turbo and RC6 to work together.

Vandana Kannan (1):
  drm/i915: Add property to set HDMI aspect ratio

Ville Syrjälä (1):
  drm/i915: Don't promote UC to WT automagically

 drivers/gpu/drm/i915/i915_drv.h|  16 
 drivers/gpu/drm/i915/i915_gem.c|   9 +-
 drivers/gpu/drm/i915/i915_gem_context.c|  15 ++--
 drivers/gpu/drm/i915/i915_gem_execbuffer.c |  15 +++-
 drivers/gpu/drm/i915/i915_irq.c| 133 -
 drivers/gpu/drm/i915/i915_reg.h|  11 +++
 drivers/gpu/drm/i915/intel_dp.c|  42 +
 drivers/gpu/drm/i915/intel_drv.h   |   4 +
 drivers/gpu/drm/i915/intel_fbdev.c |  33 +++
 drivers/gpu/drm/i915/intel_hdmi.c  |  12 +++
 drivers/gpu/drm/i915/intel_modes.c |  28 ++
 drivers/gpu/drm/i915/intel_pm.c|  18 +++-
 drivers/gpu/drm/i915/intel_ringbuffer.c|  16 +++-
 13 files changed, 318 insertions(+), 34 deletions(-)

-- 
1.9.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-07-03 Thread Rodrigo Vivi

This is another drm-intel-collector updated notice:
http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector

It was 4 rounds out of date what made it hard to get old patches. However 
Daniel and Jani didn't leave
many patches behind.
0 on Apr 4 - Apr 16
1 on Apr 16 - May 6
2 on May 6 - May 23
3 on May 23 - Jun 6

Next round Jun 6 to Jun 20 is only after next drm-intel-testing update.

Here goes the update list in order for better reviewers assignment:

Patch drm/i915: Bring UP Power Wells before disabling RC6. - Reviewer: 
Paulo Zanoni paulo.r.zan...@intel.com - Reviewer:
Patch drm/i915: Don't save/restore RS when not used - Reviewer:
Patch drm/i915: Upgrade execbuffer fail after resume failure to EIO - 
Reviewer:
Patch drm/i915: Add property to set HDMI aspect ratio - Reviewer: Ville 
Syrjälä ville.syrj...@linux.intel.com - Reviewer:
Patch drm/i915/vlv: WA for Turbo and RC6 to work together. - Reviewer:
Patch drm/i915: honour forced connector modes - Reviewer:
Patch drm/i915: HWS must be in the mappable region for g33 - Reviewer:
Patch drm/i915: Don't promote UC to WT automagically - Reviewer:
Patch drm/i915/bdw: Always issue a force restore - Reviewer:
Patch drm/i915/vlv: T12 eDP panel timing enforcement during reboot. - 
Reviewer:


There are some reasons that some patches can be left behind:
1. Your patch didn't applied cleanly and I couldn't easily solve the conflicts.
2. Kernel didn't compiled with your patch.
3. I simply missed it. If you believe this is the case please warn me.
4. Remind that any reply to your email automatically take your patch to next 
round.

Please help me to get these patches reviewed and queued by Daniel.

Thanks,
Rodrigo.


Ben Widawsky (2):
  drm/i915: Don't save/restore RS when not used
  drm/i915/bdw: Always issue a force restore

Chris Wilson (3):
  drm/i915: Upgrade execbuffer fail after resume failure to EIO
  drm/i915: honour forced connector modes
  drm/i915: HWS must be in the mappable region for g33

Clint Taylor (1):
  drm/i915/vlv: T12 eDP panel timing enforcement during reboot.

Deepak S (2):
  drm/i915: Bring UP Power Wells before disabling RC6.
  drm/i915/vlv: WA for Turbo and RC6 to work together.

Vandana Kannan (1):
  drm/i915: Add property to set HDMI aspect ratio

Ville Syrjälä (1):
  drm/i915: Don't promote UC to WT automagically

 drivers/gpu/drm/i915/i915_drv.h|  16 
 drivers/gpu/drm/i915/i915_gem.c|   9 +-
 drivers/gpu/drm/i915/i915_gem_context.c|  15 ++--
 drivers/gpu/drm/i915/i915_gem_execbuffer.c |  15 +++-
 drivers/gpu/drm/i915/i915_irq.c| 133 -
 drivers/gpu/drm/i915/i915_reg.h|  11 +++
 drivers/gpu/drm/i915/intel_dp.c|  42 +
 drivers/gpu/drm/i915/intel_drv.h   |   4 +
 drivers/gpu/drm/i915/intel_fbdev.c |  33 +++
 drivers/gpu/drm/i915/intel_hdmi.c  |  12 +++
 drivers/gpu/drm/i915/intel_modes.c |  28 ++
 drivers/gpu/drm/i915/intel_pm.c|  18 +++-
 drivers/gpu/drm/i915/intel_ringbuffer.c|  16 +++-
 13 files changed, 318 insertions(+), 34 deletions(-)

-- 
1.9.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx