Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-29 Thread Maarten Lankhorst
Op 29-06-2020 om 14:32 schreef Tvrtko Ursulin: > > On 23/06/2020 15:28, Maarten Lankhorst wrote: >> i915_gem_ww_ctx is used to lock all gem bo's for pinning and memory >> eviction. We don't use it yet, but lets start adding the definition >> first. >> >> To use it, we have to pass a non-NULL ww to

Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-29 Thread Tvrtko Ursulin
On 23/06/2020 15:28, Maarten Lankhorst wrote: i915_gem_ww_ctx is used to lock all gem bo's for pinning and memory eviction. We don't use it yet, but lets start adding the definition first. To use it, we have to pass a non-NULL ww to gem_object_lock, and don't unlock directly. It is done in

Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-29 Thread Tvrtko Ursulin
On 23/06/2020 15:28, Maarten Lankhorst wrote: i915_gem_ww_ctx is used to lock all gem bo's for pinning and memory eviction. We don't use it yet, but lets start adding the definition first. To use it, we have to pass a non-NULL ww to gem_object_lock, and don't unlock directly. It is done in

Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-24 Thread Chris Wilson
Quoting Thomas Hellström (Intel) (2020-06-24 08:49:21) > Hi, Chris, > > On 6/24/20 9:43 AM, Chris Wilson wrote: > > Quoting Thomas Hellström (Intel) (2020-06-24 08:10:43) > >> Hi, Maarten, > >> > >> > >> On 6/23/20 4:28 PM, Maarten Lankhorst wrote: > >>> i915_gem_ww_ctx is used to lock all gem

Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-24 Thread Intel
Hi, Chris, On 6/24/20 9:43 AM, Chris Wilson wrote: Quoting Thomas Hellström (Intel) (2020-06-24 08:10:43) Hi, Maarten, On 6/23/20 4:28 PM, Maarten Lankhorst wrote: i915_gem_ww_ctx is used to lock all gem bo's for pinning and memory eviction. We don't use it yet, but lets start adding the

Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-24 Thread Chris Wilson
Quoting Thomas Hellström (Intel) (2020-06-24 08:10:43) > Hi, Maarten, > > > On 6/23/20 4:28 PM, Maarten Lankhorst wrote: > > i915_gem_ww_ctx is used to lock all gem bo's for pinning and memory > > eviction. We don't use it yet, but lets start adding the definition > > first. > > > > To use it,

Re: [Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-24 Thread Intel
Hi, Maarten, On 6/23/20 4:28 PM, Maarten Lankhorst wrote: i915_gem_ww_ctx is used to lock all gem bo's for pinning and memory eviction. We don't use it yet, but lets start adding the definition first. To use it, we have to pass a non-NULL ww to gem_object_lock, and don't unlock directly. It

[Intel-gfx] [PATCH 04/26] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-06-23 Thread Maarten Lankhorst
i915_gem_ww_ctx is used to lock all gem bo's for pinning and memory eviction. We don't use it yet, but lets start adding the definition first. To use it, we have to pass a non-NULL ww to gem_object_lock, and don't unlock directly. It is done in i915_gem_ww_ctx_fini. Changes since v1: - Change