Re: [Intel-gfx] [PATCH 08/12] drm/i915: Split execlist priority queue into rbtree + linked list

2017-05-15 Thread Chris Wilson
On Mon, May 15, 2017 at 12:45:16PM +0100, Tvrtko Ursulin wrote: > > On 11/05/2017 20:59, Chris Wilson wrote: > >+if (prio == I915_PRIORITY_NORMAL) { > >+p = >default_priolist; > >+} else { > >+p = kmalloc(sizeof(*p), GFP_ATOMIC); > > I am back to being nervous

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Split execlist priority queue into rbtree + linked list

2017-05-15 Thread Tvrtko Ursulin
On 11/05/2017 20:59, Chris Wilson wrote: All the requests at the same priority are executed in FIFO order. They do not need to be stored in the rbtree themselves, as they are a simple list within a level. If we move the requests at one priority into a list, we can then reduce the rbtree to the

[Intel-gfx] [PATCH 08/12] drm/i915: Split execlist priority queue into rbtree + linked list

2017-05-11 Thread Chris Wilson
All the requests at the same priority are executed in FIFO order. They do not need to be stored in the rbtree themselves, as they are a simple list within a level. If we move the requests at one priority into a list, we can then reduce the rbtree to the set of priorities. This should keep the