Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

2016-10-26 Thread Chris Wilson
On Wed, Oct 26, 2016 at 04:15:39PM +0300, Ville Syrjälä wrote: > On Wed, Oct 26, 2016 at 02:11:00PM +0100, Chris Wilson wrote: > > On Wed, Oct 26, 2016 at 02:17:16PM +0300, Ville Syrjälä wrote: > > > On Wed, Oct 26, 2016 at 12:51:41PM +0300, Jani Nikula wrote: > > > > On Wed, 26 Oct 2016, Chris

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

2016-10-26 Thread Ville Syrjälä
On Wed, Oct 26, 2016 at 02:11:00PM +0100, Chris Wilson wrote: > On Wed, Oct 26, 2016 at 02:17:16PM +0300, Ville Syrjälä wrote: > > On Wed, Oct 26, 2016 at 12:51:41PM +0300, Jani Nikula wrote: > > > On Wed, 26 Oct 2016, Chris Wilson wrote: > > > > On Wed, Oct 26, 2016 at

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

2016-10-26 Thread Chris Wilson
On Wed, Oct 26, 2016 at 02:17:16PM +0300, Ville Syrjälä wrote: > On Wed, Oct 26, 2016 at 12:51:41PM +0300, Jani Nikula wrote: > > On Wed, 26 Oct 2016, Chris Wilson wrote: > > > On Wed, Oct 26, 2016 at 07:52:26AM +0200, Daniel Vetter wrote: > > >> I'd go further and just

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

2016-10-26 Thread Ville Syrjälä
On Wed, Oct 26, 2016 at 12:51:41PM +0300, Jani Nikula wrote: > On Wed, 26 Oct 2016, Chris Wilson wrote: > > On Wed, Oct 26, 2016 at 07:52:26AM +0200, Daniel Vetter wrote: > >> I'd go further and just always create this as one of the standard > >> properties (and always

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

2016-10-26 Thread Jani Nikula
On Wed, 26 Oct 2016, Chris Wilson wrote: > On Wed, Oct 26, 2016 at 07:52:26AM +0200, Daniel Vetter wrote: >> I'd go further and just always create this as one of the standard >> properties (and always attach it to the connector, like edid), and only >> expose helpers to

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

2016-10-26 Thread Chris Wilson
On Wed, Oct 26, 2016 at 07:52:26AM +0200, Daniel Vetter wrote: > I'd go further and just always create this as one of the standard > properties (and always attach it to the connector, like edid), and only > expose helpers to set the link status to good or bad. One of the sketches for this idea

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

2016-10-26 Thread Chris Wilson
On Tue, Oct 25, 2016 at 06:19:47PM -0700, Manasi Navare wrote: > Chris, > > Would you be able to make the necessary changes in the suerspace > driver so I can do some testing tomorrow? > > Manasi > > On Tue, Oct 25, 2016 at 06:16:34PM -0700, Manasi Navare wrote: > > A new optional connector

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

2016-10-25 Thread Daniel Vetter
On Tue, Oct 25, 2016 at 06:16:34PM -0700, Manasi Navare wrote: > A new optional connector property is added for keeping > track of whether the link is good (link training passed) or > link is bad (link training failed). If the link status property > is Bad, then userspace should fire off a new

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

2016-10-25 Thread Manasi Navare
Chris, Would you be able to make the necessary changes in the suerspace driver so I can do some testing tomorrow? Manasi On Tue, Oct 25, 2016 at 06:16:34PM -0700, Manasi Navare wrote: > A new optional connector property is added for keeping > track of whether the link is good (link training

[Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

2016-10-25 Thread Manasi Navare
A new optional connector property is added for keeping track of whether the link is good (link training passed) or link is bad (link training failed). If the link status property is Bad, then userspace should fire off a new modeset at the current mode even if there have not been any changes in