Re: [Intel-gfx] [PATCH 1/4] [v2] drm/i915: Remove node only when allocated

2013-08-15 Thread Ben Widawsky
On Thu, Aug 15, 2013 at 04:05:56PM +0200, Daniel Vetter wrote: On Wed, Aug 14, 2013 at 10:15:50AM +0200, Daniel Vetter wrote: On Wed, Aug 14, 2013 at 10:06:30AM +0200, Daniel Vetter wrote: On Tue, Aug 13, 2013 at 06:09:06PM -0700, Ben Widawsky wrote: VMAs can be created and not bound.

Re: [Intel-gfx] [PATCH 1/4] [v2] drm/i915: Remove node only when allocated

2013-08-14 Thread Daniel Vetter
On Tue, Aug 13, 2013 at 06:09:06PM -0700, Ben Widawsky wrote: VMAs can be created and not bound. One may think of it as lazy cleanup, and safely gloss over the conditions which manufacture it. In either case, when the object backing the i915 vma is destroyed, we must cleanup the vma without

Re: [Intel-gfx] [PATCH 1/4] [v2] drm/i915: Remove node only when allocated

2013-08-14 Thread Daniel Vetter
On Wed, Aug 14, 2013 at 10:06:30AM +0200, Daniel Vetter wrote: On Tue, Aug 13, 2013 at 06:09:06PM -0700, Ben Widawsky wrote: VMAs can be created and not bound. One may think of it as lazy cleanup, and safely gloss over the conditions which manufacture it. In either case, when the object

Re: [Intel-gfx] [PATCH 1/4] [v2] drm/i915: Remove node only when allocated

2013-08-14 Thread Chris Wilson
On Tue, Aug 13, 2013 at 06:09:06PM -0700, Ben Widawsky wrote: VMAs can be created and not bound. One may think of it as lazy cleanup, and safely gloss over the conditions which manufacture it. In either case, when the object backing the i915 vma is destroyed, we must cleanup the vma without

[Intel-gfx] [PATCH 1/4] [v2] drm/i915: Remove node only when allocated

2013-08-13 Thread Ben Widawsky
VMAs can be created and not bound. One may think of it as lazy cleanup, and safely gloss over the conditions which manufacture it. In either case, when the object backing the i915 vma is destroyed, we must cleanup the vma without stumbling into a bunch of pitfalls that assume the vma is bound.