Re: [Intel-gfx] [PATCH 1/4] drm/i915: Verify the engine after acquiring the active.lock

2019-09-19 Thread Tvrtko Ursulin
On 18/09/2019 15:54, Chris Wilson wrote: When using virtual engines, the rq->engine is not stable until we hold the engine->active.lock (as the virtual engine may be exchanged with the sibling). Since commit 22b7a426bbe1 ("drm/i915/execlists: Preempt-to-busy") we may retire a request

[Intel-gfx] [PATCH 1/4] drm/i915: Verify the engine after acquiring the active.lock

2019-09-18 Thread Chris Wilson
When using virtual engines, the rq->engine is not stable until we hold the engine->active.lock (as the virtual engine may be exchanged with the sibling). Since commit 22b7a426bbe1 ("drm/i915/execlists: Preempt-to-busy") we may retire a request concurrently with resubmitting it to HW, we need to be