Re: [Intel-gfx] [PATCH 1/4] drm/xe: Only set PCI d3cold_allowed when we are really allowing.

2023-07-25 Thread Rodrigo Vivi
On Tue, Jul 25, 2023 at 01:08:11AM -0400, Gupta, Anshuman wrote: > > > > -Original Message- > > From: Vivi, Rodrigo > > Sent: Saturday, July 22, 2023 12:30 AM > > To: Gupta, Anshuman > > Cc: intel-gfx@lists.freedesktop.org > > Subject: Re: [PATCH 1/4] drm/xe: Only set PCI

Re: [Intel-gfx] [PATCH 1/4] drm/xe: Only set PCI d3cold_allowed when we are really allowing.

2023-07-24 Thread Gupta, Anshuman
> -Original Message- > From: Vivi, Rodrigo > Sent: Saturday, July 22, 2023 12:30 AM > To: Gupta, Anshuman > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/4] drm/xe: Only set PCI d3cold_allowed when we are > really allowing. > > On Fri, Jul 21, 2023 at 03:39:35AM -0400,

Re: [Intel-gfx] [PATCH 1/4] drm/xe: Only set PCI d3cold_allowed when we are really allowing.

2023-07-21 Thread Rodrigo Vivi
On Fri, Jul 21, 2023 at 03:39:35AM -0400, Gupta, Anshuman wrote: > > > > -Original Message- > > From: Vivi, Rodrigo > > Sent: Friday, July 21, 2023 2:34 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Vivi, Rodrigo ; Gupta, Anshuman > > > > Subject: [PATCH 1/4] drm/xe: Only set PCI

Re: [Intel-gfx] [PATCH 1/4] drm/xe: Only set PCI d3cold_allowed when we are really allowing.

2023-07-21 Thread Gupta, Anshuman
> -Original Message- > From: Vivi, Rodrigo > Sent: Friday, July 21, 2023 2:34 AM > To: intel-gfx@lists.freedesktop.org > Cc: Vivi, Rodrigo ; Gupta, Anshuman > > Subject: [PATCH 1/4] drm/xe: Only set PCI d3cold_allowed when we are > really allowing. > > First of all it was strange to

[Intel-gfx] [PATCH 1/4] drm/xe: Only set PCI d3cold_allowed when we are really allowing.

2023-07-20 Thread Rodrigo Vivi
First of all it was strange to see: if (allowed) { ... } else { D3COLD_ENABLE } But besides this misalignment, let's also use the pci d3cold_allowed useful to us and know that we are not really allowing d3cold. Cc: Anshuman Gupta Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_pci.c