Re: [Intel-gfx] [PATCH 1/4] drm: Support legacy cursor ioctls via universal planes when possible (v2)

2014-05-20 Thread Daniel Vetter
On Mon, May 19, 2014 at 03:25:45PM -0700, Matt Roper wrote: On Sat, May 17, 2014 at 12:43:04AM +0200, Daniel Vetter wrote: On Sat, May 17, 2014 at 12:38 AM, Matt Roper matthew.d.ro...@intel.com wrote: + if (ret) { + if (req-flags DRM_MODE_CURSOR_BO) +

Re: [Intel-gfx] [PATCH 1/4] drm: Support legacy cursor ioctls via universal planes when possible (v2)

2014-05-19 Thread Daniel Vetter
I didn't spot anything else, so with the below issue addressed this patch is Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch On Sat, May 17, 2014 at 12:43:04AM +0200, Daniel Vetter wrote: On Sat, May 17, 2014 at 12:38 AM, Matt Roper matthew.d.ro...@intel.com wrote: + if (ret) { +

Re: [Intel-gfx] [PATCH 1/4] drm: Support legacy cursor ioctls via universal planes when possible (v2)

2014-05-19 Thread Matt Roper
On Sat, May 17, 2014 at 12:43:04AM +0200, Daniel Vetter wrote: On Sat, May 17, 2014 at 12:38 AM, Matt Roper matthew.d.ro...@intel.com wrote: + if (ret) { + if (req-flags DRM_MODE_CURSOR_BO) + drm_mode_rmfb(dev, fb-base.id, file_priv); +

[Intel-gfx] [PATCH 1/4] drm: Support legacy cursor ioctls via universal planes when possible (v2)

2014-05-16 Thread Matt Roper
If drivers support universal planes and have registered a cursor plane with the DRM core, we should use that universal plane support when handling legacy cursor ioctls. Drivers that transition to universal planes won't have to maintain separate legacy ioctl handling; drivers that don't transition

Re: [Intel-gfx] [PATCH 1/4] drm: Support legacy cursor ioctls via universal planes when possible (v2)

2014-05-16 Thread Daniel Vetter
On Sat, May 17, 2014 at 12:38 AM, Matt Roper matthew.d.ro...@intel.com wrote: + if (ret) { + if (req-flags DRM_MODE_CURSOR_BO) + drm_mode_rmfb(dev, fb-base.id, file_priv); + return ret; + } With the new refcount logic an