Re: [Intel-gfx] [PATCH 1/6] drm/i915: Make a copy of the ggtt view for slave plane

2020-01-13 Thread Juha-Pekka Heikkila
On 10.1.2020 20.32, Ville Syrjala wrote: From: Ville Syrjälä intel_prepare_plane_fb() will always pin plane_state->hw.fb whenever it is present. We copy that from the master plane to the slave plane, but we fail to copy the corresponding ggtt view. Thus when it comes time to pin the slave

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Make a copy of the ggtt view for slave plane

2020-01-13 Thread Chris Wilson
Quoting Ville Syrjälä (2020-01-13 13:15:16) > On Fri, Jan 10, 2020 at 06:54:13PM +, Chris Wilson wrote: > > Quoting Ville Syrjala (2020-01-10 18:32:23) > > > From: Ville Syrjälä > > > > > > intel_prepare_plane_fb() will always pin plane_state->hw.fb whenever > > > it is present. We copy that

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Make a copy of the ggtt view for slave plane

2020-01-13 Thread Ville Syrjälä
On Fri, Jan 10, 2020 at 06:54:13PM +, Chris Wilson wrote: > Quoting Ville Syrjala (2020-01-10 18:32:23) > > From: Ville Syrjälä > > > > intel_prepare_plane_fb() will always pin plane_state->hw.fb whenever > > it is present. We copy that from the master plane to the slave plane, > > but we

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Make a copy of the ggtt view for slave plane

2020-01-10 Thread Chris Wilson
Quoting Ville Syrjala (2020-01-10 18:32:23) > From: Ville Syrjälä > > intel_prepare_plane_fb() will always pin plane_state->hw.fb whenever > it is present. We copy that from the master plane to the slave plane, > but we fail to copy the corresponding ggtt view. Thus when it comes time > to pin

[Intel-gfx] [PATCH 1/6] drm/i915: Make a copy of the ggtt view for slave plane

2020-01-10 Thread Ville Syrjala
From: Ville Syrjälä intel_prepare_plane_fb() will always pin plane_state->hw.fb whenever it is present. We copy that from the master plane to the slave plane, but we fail to copy the corresponding ggtt view. Thus when it comes time to pin the slave plane's fb we use some stale ggtt view left