Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-11 Thread Matthew Garrett
On Wed, 2013-09-11 at 11:45 +0300, Jani Nikula wrote: Before plunging forward, have you observed any difference between the boot modes? We have reports [1] that the backlight behaviour is different with UEFI vs. UEFI+CSM or legacy boot. So I'm wondering if the acpi_gbl_osi_data =

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-11 Thread Yves-Alexis Perez
On mer., 2013-09-11 at 08:45 +, Matthew Garrett wrote: On Wed, 2013-09-11 at 11:45 +0300, Jani Nikula wrote: Before plunging forward, have you observed any difference between the boot modes? We have reports [1] that the backlight behaviour is different with UEFI vs. UEFI+CSM or legacy

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-11 Thread Jani Nikula
On Wed, 11 Sep 2013, Matthew Garrett matthew.garr...@nebula.com wrote: On Wed, 2013-09-11 at 11:45 +0300, Jani Nikula wrote: Before plunging forward, have you observed any difference between the boot modes? We have reports [1] that the backlight behaviour is different with UEFI vs. UEFI+CSM

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-11 Thread Matthew Garrett
On Wed, 2013-09-11 at 13:29 +0300, Jani Nikula wrote: On Wed, 11 Sep 2013, Matthew Garrett matthew.garr...@nebula.com wrote: On Wed, 2013-09-11 at 11:45 +0300, Jani Nikula wrote: Before plunging forward, have you observed any difference between the boot modes? We have reports [1] that the

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-11 Thread Aaron Lu
On Wed, Sep 11, 2013 at 11:45:19AM +0300, Jani Nikula wrote: On Wed, 11 Sep 2013, Aaron Lu aaron...@intel.com wrote: It is possible the i915 driver decides not to register a backlight interface for the graphics card for some reason(memory allocation failed or it knows the native control

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-10 Thread Aaron Lu
On Mon, Sep 09, 2013 at 11:32:10AM +0200, Daniel Vetter wrote: Hi Aaaron, Have we grown any clue meanwhile about which Intel boxes need this and for which we still need to keep the acpi backlight around? I've grown _very_ Sorry, no general rule has been found. As Rafael has said, it appears

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-10 Thread Jani Nikula
On Mon, 09 Sep 2013, Rafael J. Wysocki r...@sisk.pl wrote: On Monday, September 09, 2013 05:21:18 PM Daniel Vetter wrote: On Mon, Sep 09, 2013 at 02:16:12PM +0200, Rafael J. Wysocki wrote: Hi, On Monday, September 09, 2013 11:32:10 AM Daniel Vetter wrote: Hi Aaaron, Have we

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-10 Thread Matthew Garrett
On Tue, 2013-09-10 at 16:53 +0300, Jani Nikula wrote: I think the parameter Does the ACPI backlight interface work or not belongs to the ACPI video driver. That depends on how Windows 8 works. If Windows 8 policy is handled by the GPU drivers then it belongs in i915. If it's handled by the

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-10 Thread Matthew Garrett
On Tue, 2013-09-10 at 17:21 +0300, Jani Nikula wrote: On Tue, 10 Sep 2013, Matthew Garrett matthew.garr...@nebula.com wrote: On Tue, 2013-09-10 at 16:53 +0300, Jani Nikula wrote: I think the parameter Does the ACPI backlight interface work or not belongs to the ACPI video driver. That

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-10 Thread Rafael J. Wysocki
On Tuesday, September 10, 2013 04:53:40 PM Jani Nikula wrote: On Mon, 09 Sep 2013, Rafael J. Wysocki r...@sisk.pl wrote: On Monday, September 09, 2013 05:21:18 PM Daniel Vetter wrote: On Mon, Sep 09, 2013 at 02:16:12PM +0200, Rafael J. Wysocki wrote: Hi, On Monday, September 09,

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-10 Thread Aaron Lu
On Tue, Sep 10, 2013 at 09:23:04PM +0200, Rafael J. Wysocki wrote: On Tuesday, September 10, 2013 04:53:40 PM Jani Nikula wrote: On Mon, 09 Sep 2013, Rafael J. Wysocki r...@sisk.pl wrote: On Monday, September 09, 2013 05:21:18 PM Daniel Vetter wrote: On Mon, Sep 09, 2013 at 02:16:12PM

[Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Aaron Lu
According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel driver for Windows [8] doesn't use the ACPI interface, including the fact that it's broken on a bunch of

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Daniel Vetter
Hi Aaaron, Have we grown any clue meanwhile about which Intel boxes need this and for which we still need to keep the acpi backlight around? I've grown _very_ reluctant to just adding tons of quirks to our driver for the backlight. Almost all the quirks we have added recently (or that have been

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Igor Gnatenko
On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index f466980..75fba17 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -1650,7 +1650,7 @@ int i915_driver_load(struct

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Rafael J. Wysocki
Hi, On Monday, September 09, 2013 11:32:10 AM Daniel Vetter wrote: Hi Aaaron, Have we grown any clue meanwhile about which Intel boxes need this and for which we still need to keep the acpi backlight around? First of all, there is a bunch of boxes where ACPI backlight works incorrectly

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Daniel Vetter
On Mon, Sep 09, 2013 at 02:16:12PM +0200, Rafael J. Wysocki wrote: Hi, On Monday, September 09, 2013 11:32:10 AM Daniel Vetter wrote: Hi Aaaron, Have we grown any clue meanwhile about which Intel boxes need this and for which we still need to keep the acpi backlight around? First

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Rafael J. Wysocki
On Monday, September 09, 2013 05:21:18 PM Daniel Vetter wrote: On Mon, Sep 09, 2013 at 02:16:12PM +0200, Rafael J. Wysocki wrote: Hi, On Monday, September 09, 2013 11:32:10 AM Daniel Vetter wrote: Hi Aaaron, Have we grown any clue meanwhile about which Intel boxes need this and

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Aaron Lu
On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index f466980..75fba17 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Igor Gnatenko
On Tue, 2013-09-10 at 11:27 +0800, Aaron Lu wrote: On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index f466980..75fba17 100644 ---

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Aaron Lu
On 09/10/2013 01:13 PM, Igor Gnatenko wrote: On Tue, 2013-09-10 at 11:27 +0800, Aaron Lu wrote: On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Igor Gnatenko
On Tue, 2013-09-10 at 13:16 +0800, Aaron Lu wrote: On 09/10/2013 01:13 PM, Igor Gnatenko wrote: On Tue, 2013-09-10 at 11:27 +0800, Aaron Lu wrote: On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff --git a/drivers/gpu/drm/i915/i915_dma.c

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Igor Gnatenko
On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel driver for Windows [8] doesn't use the ACPI

Re: [Intel-gfx] [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-09 Thread Aaron Lu
On 09/10/2013 01:22 PM, Igor Gnatenko wrote: On Tue, 2013-09-10 at 13:16 +0800, Aaron Lu wrote: On 09/10/2013 01:13 PM, Igor Gnatenko wrote: On Tue, 2013-09-10 at 11:27 +0800, Aaron Lu wrote: On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff