[Intel-gfx] [PATCH 2/2] drm/i915/i9xx_wm: Prefer intel_de functions over intel_uncore.

2023-03-27 Thread Rodrigo Vivi
Let's get rid of the intel_uncore calls on display side. v2: Fix multiple CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis Cc: Jani Nikula Signed-off-by: Rodrigo Vivi Reviewed-by: Ville Syrjälä Link:

Re: [Intel-gfx] [PATCH 2/2] drm/i915/i9xx_wm: Prefer intel_de functions over intel_uncore.

2023-03-08 Thread Ville Syrjälä
On Wed, Mar 08, 2023 at 08:18:52PM +0200, Ville Syrjälä wrote: > On Wed, Mar 08, 2023 at 12:56:28PM -0500, Rodrigo Vivi wrote: > > On Wed, Mar 08, 2023 at 07:50:27PM +0200, Ville Syrjälä wrote: > > > On Wed, Mar 08, 2023 at 11:58:59AM -0500, Rodrigo Vivi wrote: > > > > } else if

Re: [Intel-gfx] [PATCH 2/2] drm/i915/i9xx_wm: Prefer intel_de functions over intel_uncore.

2023-03-08 Thread Ville Syrjälä
On Wed, Mar 08, 2023 at 12:56:28PM -0500, Rodrigo Vivi wrote: > On Wed, Mar 08, 2023 at 07:50:27PM +0200, Ville Syrjälä wrote: > > On Wed, Mar 08, 2023 at 11:58:59AM -0500, Rodrigo Vivi wrote: > > > } else if (IS_I915GM(dev_priv)) { > > > /* > > >* FIXME can't find a bit

Re: [Intel-gfx] [PATCH 2/2] drm/i915/i9xx_wm: Prefer intel_de functions over intel_uncore.

2023-03-08 Thread Rodrigo Vivi
On Wed, Mar 08, 2023 at 07:50:27PM +0200, Ville Syrjälä wrote: > On Wed, Mar 08, 2023 at 11:58:59AM -0500, Rodrigo Vivi wrote: > > } else if (IS_I915GM(dev_priv)) { > > /* > > * FIXME can't find a bit like this for 915G, and > > * yet it does have the

Re: [Intel-gfx] [PATCH 2/2] drm/i915/i9xx_wm: Prefer intel_de functions over intel_uncore.

2023-03-08 Thread Ville Syrjälä
On Wed, Mar 08, 2023 at 11:58:59AM -0500, Rodrigo Vivi wrote: > } else if (IS_I915GM(dev_priv)) { > /* >* FIXME can't find a bit like this for 915G, and >* yet it does have the related watermark in >* FW_BLC_SELF. What's going on?

[Intel-gfx] [PATCH 2/2] drm/i915/i9xx_wm: Prefer intel_de functions over intel_uncore.

2023-03-08 Thread Rodrigo Vivi
Let's get rid of the intel_uncore calls on display side. Cc: Jani Nikula Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/display/i9xx_wm.c | 238 drivers/gpu/drm/i915/display/intel_de.h | 12 ++ 2 files changed, 131 insertions(+), 119 deletions(-) diff --git