Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-24 Thread Dixit, Ashutosh
On Wed, 24 May 2023 10:53:20 -0700, Tvrtko Ursulin wrote: > Hi Tvrtko, > On 24/05/2023 18:38, Dixit, Ashutosh wrote: > > On Wed, 24 May 2023 04:38:18 -0700, Tvrtko Ursulin wrote: > >> On 23/05/2023 16:19, Ashutosh Dixit wrote: > >>> No functional changes but we can remove some unsightly index

[Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-24 Thread Ashutosh Dixit
No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample array from a one-dimensional to a two-dimensional array. v2: Retain read/store helpers (Tvrtko) Suggested-by: Tvrtko Ursulin Reviewed-by: Andrzej Hajda Reviewed-by:

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-24 Thread Tvrtko Ursulin
On 24/05/2023 18:38, Dixit, Ashutosh wrote: On Wed, 24 May 2023 04:38:18 -0700, Tvrtko Ursulin wrote: Hi Tvrtko, On 23/05/2023 16:19, Ashutosh Dixit wrote: No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-24 Thread Dixit, Ashutosh
On Wed, 24 May 2023 04:38:18 -0700, Tvrtko Ursulin wrote: > Hi Tvrtko, > On 23/05/2023 16:19, Ashutosh Dixit wrote: > > No functional changes but we can remove some unsightly index computation > > and read/write functions if we convert the PMU sample array from a > > one-dimensional to a

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-24 Thread Tvrtko Ursulin
On 23/05/2023 16:19, Ashutosh Dixit wrote: No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample array from a one-dimensional to a two-dimensional array. Suggested-by: Tvrtko Ursulin Signed-off-by: Ashutosh Dixit ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-24 Thread Andrzej Hajda
On 23.05.2023 17:19, Ashutosh Dixit wrote: No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample array from a one-dimensional to a two-dimensional array. Suggested-by: Tvrtko Ursulin Signed-off-by: Ashutosh Dixit

[Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-23 Thread Ashutosh Dixit
No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample array from a one-dimensional to a two-dimensional array. Suggested-by: Tvrtko Ursulin Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_pmu.c | 60