Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-11 Thread Hans de Goede
Hi, On 11-12-2019 01:24, Linus Walleij wrote: On Mon, Dec 2, 2019 at 4:49 PM Hans de Goede wrote: There is only one problem, currently is is not possible to unregister a mapping added with pinctrl_register_mappings and the i915 driver is typically a module which can be unloaded and I believe

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-10 Thread Linus Walleij
On Mon, Dec 2, 2019 at 4:49 PM Hans de Goede wrote: > There is only one problem, currently is is not possible to > unregister a mapping added with pinctrl_register_mappings > and the i915 driver is typically a module which can be unloaded > and I believe actually is unloaded as part of the i915

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-02 Thread Hans de Goede
HI, On 02-12-2019 12:53, Jani Nikula wrote: On Mon, 02 Dec 2019, Linus Walleij wrote: Hi Hans, thank you for your patch! On Fri, Nov 29, 2019 at 7:58 PM Hans de Goede wrote: - /* GPIO Desc for CRC based Panel control */ + /* GPIO Desc for panel and backlight control */

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-02 Thread Jani Nikula
On Mon, 02 Dec 2019, Linus Walleij wrote: > Hi Hans, > > thank you for your patch! > > On Fri, Nov 29, 2019 at 7:58 PM Hans de Goede wrote: > >> - /* GPIO Desc for CRC based Panel control */ >> + /* GPIO Desc for panel and backlight control */ >> struct gpio_desc *gpio_panel;

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-02 Thread Linus Walleij
Hi Hans, thank you for your patch! On Fri, Nov 29, 2019 at 7:58 PM Hans de Goede wrote: > - /* GPIO Desc for CRC based Panel control */ > + /* GPIO Desc for panel and backlight control */ > struct gpio_desc *gpio_panel; > + struct gpio_desc *gpio_backlight; I think

[Intel-gfx] [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-11-29 Thread Hans de Goede
On Bay Trail devices the MIPI power on/off sequences for DSI LCD panels do not control the LCD panel- and backlight-enable GPIOs. So far, when the VBT indicates we should use the SoC for backlight control, we have been relying on these GPIOs being configured as output and driven high by the Video