Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix up address spaces in slow_kernel_write()

2010-05-28 Thread Chris Wilson
On Fri, 28 May 2010 11:28:50 +0200, Daniel Vetter wrote: > On Thu, May 27, 2010 at 02:15:35PM +0100, Chris Wilson wrote: > > Since we now get_user_pages() outside of the mutex prior to performing > > the copy, we kmap() the page inside the copy routine and so need to > > perform an ordinary memcpy

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix up address spaces in slow_kernel_write()

2010-05-28 Thread Daniel Vetter
On Thu, May 27, 2010 at 02:15:35PM +0100, Chris Wilson wrote: > Since we now get_user_pages() outside of the mutex prior to performing > the copy, we kmap() the page inside the copy routine and so need to > perform an ordinary memcpy() and not copy_from_user(). Patches look sane and will definitel

[Intel-gfx] [PATCH 2/2] drm/i915: Fix up address spaces in slow_kernel_write()

2010-05-27 Thread Chris Wilson
Since we now get_user_pages() outside of the mutex prior to performing the copy, we kmap() the page inside the copy routine and so need to perform an ordinary memcpy() and not copy_from_user(). Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 42 +++