[Intel-gfx] [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default
This is yet another chapter in the ongoing saga of bringing RC6 to Sandy
Bridge machines by default.
Now that we have discovered that RC6 issues are triggered by RC6+ state,
let's try to disable it by default. Plain RC6 is the one responsible for
most energy savings, and so far it haven't given any problems - at least,
none we are aware of.
So with this, when i915_enable_rc6=-1 (e.g., the default value), we'll
attempt to enable plain RC6 only on SNB. For Ivy Bridge, the behavior
stays the same as always - we enable both RC6 and deep RC6.
Note that while this exact patch does not has explicit tested-by's, the
equivalent settings were fixed in 3.3 kernel by a smaller patch. And it
has also received considerable testing through Canonical RC6 task-force
testing at https://wiki.ubuntu.com/Kernel/PowerManagementRC6. Up to date,
it looks like all the known issues are gone.
v2: improve description and reference a couple of open bugs related to
RC6 which seem to be fixed with this change.
References: https://bugs.freedesktop.org/show_bug.cgi?id=41682
References: https://bugs.freedesktop.org/show_bug.cgi?id=38567
References: https://bugs.freedesktop.org/show_bug.cgi?id=44867
Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com
---
drivers/gpu/drm/i915/intel_display.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index c6d8bc4..dcae2c9 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -8233,11 +8233,11 @@ static int intel_enable_rc6(struct drm_device *dev)
* Disable rc6 on Sandybridge
*/
if (INTEL_INFO(dev)-gen == 6) {
- DRM_DEBUG_DRIVER(Sandybridge: RC6 disabled\n);
- return 0;
+ DRM_DEBUG_DRIVER(Sandybridge: deep RC6 disabled\n);
+ return INTEL_RC6_ENABLE;
}
- DRM_DEBUG_DRIVER(RC6 enabled\n);
- return 1;
+ DRM_DEBUG_DRIVER(RC6 and deep RC6 enabled\n);
+ return (INTEL_RC6_ENABLE | INTEL_RC6p_ENABLE);
}
void gen6_enable_rps(struct drm_i915_private *dev_priv)
--
1.7.9.4
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default
On Fri, 23 Mar 2012 11:57:19 -0300, Eugeni Dodonov eugeni.dodo...@intel.com wrote: This is yet another chapter in the ongoing saga of bringing RC6 to Sandy Bridge machines by default. Now that we have discovered that RC6 issues are triggered by RC6+ state, let's try to disable it by default. Plain RC6 is the one responsible for most energy savings, and so far it haven't given any problems - at least, none we are aware of. So with this, when i915_enable_rc6=-1 (e.g., the default value), we'll attempt to enable plain RC6 only on SNB. For Ivy Bridge, the behavior stays the same as always - we enable both RC6 and deep RC6. Note that while this exact patch does not has explicit tested-by's, the equivalent settings were fixed in 3.3 kernel by a smaller patch. And it has also received considerable testing through Canonical RC6 task-force testing at https://wiki.ubuntu.com/Kernel/PowerManagementRC6. Up to date, it looks like all the known issues are gone. v2: improve description and reference a couple of open bugs related to RC6 which seem to be fixed with this change. References: https://bugs.freedesktop.org/show_bug.cgi?id=41682 References: https://bugs.freedesktop.org/show_bug.cgi?id=38567 References: https://bugs.freedesktop.org/show_bug.cgi?id=44867 Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com Acked-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default
#part sign=pgpmime On Sun, 12 Feb 2012 22:34:48 -0200, Eugeni Dodonov eug...@dodonov.net wrote: what if we pick only the 1st patch in this series for -fixes? It won't change the defaults in any way, but it will allow the ones willing to enable it manually on SNB to prevent issues. That seems like too big a change at this point in the release cycle. We should be focused purely on fixing functionality bugs, not adding new features. So, instead of adding the ability to individually control RC6 levels, we should just change what RC6 does on SNB when it is enabled, then encourage people to test that and see if the shallowest RC6 states actually work. That will provide sufficient information to know whether it will be safe to turn that on by default in the next release, which is what we really want. The smallest change that gives us the data we need is what I'd like to have. -- keith.pack...@intel.com ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default
This is yet another chapter in the ongoing saga of bringing RC6 to Sandy
Bridge machines by default.
Now that we have discovered that RC6 issues are triggered by RC6+ state,
let's try to disable it by default. Plain RC6 is the one responsible for
most energy savings, and so far it haven't given any problems - at least,
none we are aware of.
So with this, when i915_enable_rc6=-1 (e.g., the default value), we'll
attempt to enable plain RC6 only on SNB. For Ivy Bridge, the behavior
stays the same as always - we enable both RC6 and deep RC6.
Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com
---
drivers/gpu/drm/i915/intel_display.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index d636fc2..a1e3329 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7925,11 +7925,11 @@ static int intel_enable_rc6(struct drm_device *dev)
* Disable rc6 on Sandybridge
*/
if (INTEL_INFO(dev)-gen == 6) {
- DRM_DEBUG_DRIVER(Sandybridge: RC6 disabled\n);
- return 0;
+ DRM_DEBUG_DRIVER(Sandybridge: deep RC6 disabled\n);
+ return INTEL_RC6_ENABLE;
}
- DRM_DEBUG_DRIVER(RC6 enabled\n);
- return 1;
+ DRM_DEBUG_DRIVER(RC6 and deep RC6 enabled\n);
+ return (INTEL_RC6_ENABLE | INTEL_RC6p_ENABLE);
}
void gen6_enable_rps(struct drm_i915_private *dev_priv)
--
1.7.8.4
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default
On Sat, Feb 11, 2012 at 10:59, Chris Wilson ch...@chris-wilson.co.ukwrote: On Sat, 11 Feb 2012 10:34:15 -0200, Eugeni Dodonov eugeni.dodo...@intel.com wrote: This is yet another chapter in the ongoing saga of bringing RC6 to Sandy Bridge machines by default. Now that we have discovered that RC6 issues are triggered by RC6+ state, let's try to disable it by default. Plain RC6 is the one responsible for most energy savings, and so far it haven't given any problems - at least, none we are aware of. So with this, when i915_enable_rc6=-1 (e.g., the default value), we'll attempt to enable plain RC6 only on SNB. For Ivy Bridge, the behavior stays the same as always - we enable both RC6 and deep RC6. We appear to be lacking a bunch of tested-bys for what we proclaim to have been tested. So far I had 2 reports saying that RC6 solved the problems which were present with RC6+RC6p (previous default) on SNB. I'll wait a bit more and send a v2 version of this patch with all the Tested-by's. Indeed, it makes sense to have those on this patch before picking it into any kernel tree. Meanwhile, if there are any other volunteers who were affected by SNB RC6 voodoo in the past and are willing to give these patches a try, please, do so! (Not that it wouldn't prevent all the possible issues, but it would certify that it is not a placebo effect at least for someone...) -- Eugeni Dodonov http://eugeni.dodonov.net/ ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default
Hi! I think it's not just a placebo effect. I'm one of the users affected by video corruption with rc6 enabled. Now I have used my pc for two days with the patched kernel and everything seem working just fine. The glitches that I had with the previous kernel versions were very noticeable and sometimes covered more than half the screen, as I showed to Eugeni. I can understand that after the previous experiences you'd like to move slowly, but as much as I can tell, rc6 now is working as it should, so far. Of course I will continue testing (using, actually) this version of the kernel to provide info in case something goes wrong. Cheers, Luigi ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
