Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add thread stall DOP clock gating workaround on Broadwell.

2014-08-05 Thread Ville Syrjälä
On Mon, Aug 04, 2014 at 11:15:14AM -0700, Rodrigo Vivi wrote:
 From: Kenneth Graunke kenn...@whitecape.org
 
 Ben and I believe this will be necessary on production hardware.
 
 Signed-off-by: Kenneth Graunke kenn...@whitecape.org
 Signed-off-by: Ben Widawsky b...@bwidawsk.net
 Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com
 ---
  drivers/gpu/drm/i915/intel_pm.c | 4 
  1 file changed, 4 insertions(+)
 
 diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
 index 684dc5f..f919596 100644
 --- a/drivers/gpu/drm/i915/intel_pm.c
 +++ b/drivers/gpu/drm/i915/intel_pm.c
 @@ -5412,6 +5412,10 @@ static void gen8_init_clock_gating(struct drm_device 
 *dev)
   I915_WRITE(GEN8_ROW_CHICKEN,
  _MASKED_BIT_ENABLE(STALL_DOP_GATING_DISABLE));
  
 + /* WaDisableThreadStallDopClockGating:bdw */
 + I915_WRITE(GEN8_ROW_CHICKEN,
 +_MASKED_BIT_ENABLE(STALL_DOP_GATING_DISABLE));

It's already there just above.

 +
   /*
* This GEN8_CENTROID_PIXEL_OPT_DIS W/A is only needed for
* pre-production hardware
 -- 
 1.9.3
 
 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 2/7] drm/i915: Add thread stall DOP clock gating workaround on Broadwell.

2014-08-04 Thread Rodrigo Vivi
From: Kenneth Graunke kenn...@whitecape.org

Ben and I believe this will be necessary on production hardware.

Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Signed-off-by: Ben Widawsky b...@bwidawsk.net
Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com
---
 drivers/gpu/drm/i915/intel_pm.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 684dc5f..f919596 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5412,6 +5412,10 @@ static void gen8_init_clock_gating(struct drm_device 
*dev)
I915_WRITE(GEN8_ROW_CHICKEN,
   _MASKED_BIT_ENABLE(STALL_DOP_GATING_DISABLE));
 
+   /* WaDisableThreadStallDopClockGating:bdw */
+   I915_WRITE(GEN8_ROW_CHICKEN,
+  _MASKED_BIT_ENABLE(STALL_DOP_GATING_DISABLE));
+
/*
 * This GEN8_CENTROID_PIXEL_OPT_DIS W/A is only needed for
 * pre-production hardware
-- 
1.9.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx