[Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-28 Thread Ashutosh Dixit
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively). Media freq factor is converted to media_ratio_mode for GuC. It is programmed i

Re: [Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-25 Thread Dixit, Ashutosh
On Thu, 21 Apr 2022 13:57:03 -0700, Rodrigo Vivi wrote: > > On Tue, Apr 19, 2022 at 10:21:26PM -0700, Ashutosh Dixit wrote: > > > +#define U8_8_VAL_MASK 0x > > +#define U8_8_SCALE_TO_VALUE "0.00390625" > > I really like this style because it gets future proof... > Well, honestly I

Re: [Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-25 Thread Dixit, Ashutosh
On Sun, 24 Apr 2022 11:43:18 -0700, Andi Shyti wrote: > > Hi Ashutosh, Hi Andi > [...] > > > static int intel_sysfs_rps_init(struct intel_gt *gt, struct kobject *kobj, > > const struct attribute * const *attrs) > > { > > @@ -598,4 +720,12 @@ void intel_gt_sysfs_pm_in

Re: [Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-24 Thread Andi Shyti
Hi Ashutosh, [...] > static int intel_sysfs_rps_init(struct intel_gt *gt, struct kobject *kobj, > const struct attribute * const *attrs) > { > @@ -598,4 +720,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct > kobject *kobj) > drm_warn(>-

Re: [Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-21 Thread Rodrigo Vivi
On Tue, Apr 19, 2022 at 10:21:26PM -0700, Ashutosh Dixit wrote: > Expose new sysfs to program and retrieve media freq factor. Factor values > of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point > representation (corresponding to integer values of 0, 128 and 256 > respectively). > > Me

[Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-19 Thread Ashutosh Dixit
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively). Media freq factor is converted to media_ratio_mode for GuC. It is programmed i

[Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-19 Thread Ashutosh Dixit
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively). Media freq factor is converted to media_ratio_mode for GuC. It is programmed i