Re: [Intel-gfx] [PATCH 28/59] drm/mcde: Use devm_drm_dev_alloc

2020-04-15 Thread Linus Walleij
On Wed, Apr 15, 2020 at 9:41 AM Daniel Vetter  wrote:

> Already using devm_drm_dev_init, so very simple replacment.
>
> v2: Move misplaced double-assignement to next patch (Sam)
>
> Acked-by: Sam Ravnborg 
> Signed-off-by: Daniel Vetter 
> Cc: Linus Walleij 

Reviewed-by: Linus Walleij 

Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 28/59] drm/mcde: Use devm_drm_dev_alloc

2020-04-15 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment.

v2: Move misplaced double-assignement to next patch (Sam)

Acked-by: Sam Ravnborg 
Signed-off-by: Daniel Vetter 
Cc: Linus Walleij 
---
 drivers/gpu/drm/mcde/mcde_drv.c | 15 ---
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
index 88cc6b4a7a64..22003478db2c 100644
--- a/drivers/gpu/drm/mcde/mcde_drv.c
+++ b/drivers/gpu/drm/mcde/mcde_drv.c
@@ -307,19 +307,12 @@ static int mcde_probe(struct platform_device *pdev)
int ret;
int i;
 
-   mcde = kzalloc(sizeof(*mcde), GFP_KERNEL);
-   if (!mcde)
-   return -ENOMEM;
-   mcde->dev = dev;
-
-   ret = devm_drm_dev_init(dev, >drm, _drm_driver);
-   if (ret) {
-   kfree(mcde);
-   return ret;
-   }
+   mcde = devm_drm_dev_alloc(dev, _drm_driver, struct mcde, drm);
+   if (IS_ERR(mcde))
+   return PTR_ERR(mcde);
drm = >drm;
drm->dev_private = mcde;
-   drmm_add_final_kfree(drm, mcde);
+   mcde->dev = dev;
platform_set_drvdata(pdev, drm);
 
/* Enable continuous updates: this is what Linux' framebuffer expects */
-- 
2.25.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx