Re: [Intel-gfx] [PATCH 3/3] drm/i915/error: capture uc_state after gen_state

[Daniele Ceraolo Spurio]

On 03/03/18 01:55, Chris Wilson wrote:

Quoting Daniele Ceraolo Spurio (2018-03-02 19:19:30)

error->device_info.has_guc, which we check in capture_uc_state, is set
in capture_gen_state, so the latter needs to be performed first.

Reported-by: Vinay Belgaumkar 
Cc: Vinay Belgaumkar 
Cc: Michal Wajdeczko 
Cc: Chris Wilson 
Signed-off-by: Daniele Ceraolo Spurio 


Care to add a fixes in case you want this backported?



I had purposely omitted the tag as I thought that since GuC is disabled 
by default we wouldn't backport patches related to it, but I guess I had 
the wrong idea :)

I'll add the tag in v2

Thanks,
Daniele


Reviewed-by: Chris Wilson 
-Chris


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/3] drm/i915/error: capture uc_state after gen_state

[Chris Wilson]

Quoting Daniele Ceraolo Spurio (2018-03-02 19:19:30)
> error->device_info.has_guc, which we check in capture_uc_state, is set
> in capture_gen_state, so the latter needs to be performed first.
> 
> Reported-by: Vinay Belgaumkar 
> Cc: Vinay Belgaumkar 
> Cc: Michal Wajdeczko 
> Cc: Chris Wilson 
> Signed-off-by: Daniele Ceraolo Spurio 

Care to add a fixes in case you want this backported?

Reviewed-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 3/3] drm/i915/error: capture uc_state after gen_state

[Daniele Ceraolo Spurio]

error->device_info.has_guc, which we check in capture_uc_state, is set
in capture_gen_state, so the latter needs to be performed first.

Reported-by: Vinay Belgaumkar 
Cc: Vinay Belgaumkar 
Cc: Michal Wajdeczko 
Cc: Chris Wilson 
Signed-off-by: Daniele Ceraolo Spurio 
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c 
b/drivers/gpu/drm/i915/i915_gpu_error.c
index d1f96e6a723a..e39f2bd4c2ab 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1749,9 +1749,9 @@ static int capture(void *data)
  error->i915->gt.last_init_time);
 
capture_params(error);
-   capture_uc_state(i915, error);
 
capture_gen_state(i915, error);
+   capture_uc_state(i915, error);
capture_reg_state(i915, error);
gem_record_fences(i915, error);
gem_record_rings(i915, error);
-- 
2.16.2

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx