Re: [Intel-gfx] [PATCH 3/3] drm/i915/fb: Fold modifier CCS type/tiling attribute to plane caps

2021-10-27 Thread Jani Nikula
On Wed, 27 Oct 2021, Imre Deak wrote: > On Tue, Oct 26, 2021 at 08:52:12PM +0300, Jani Nikula wrote: >> AFAICT there are no intel_plane_caps references anywhere after this, and >> it no longer looks like an enum, so perhaps it just shouldn't be an enum >> anymore? Just make them macros? > > There

Re: [Intel-gfx] [PATCH 3/3] drm/i915/fb: Fold modifier CCS type/tiling attribute to plane caps

2021-10-27 Thread Imre Deak
On Tue, Oct 26, 2021 at 08:52:12PM +0300, Jani Nikula wrote: > On Tue, 26 Oct 2021, Imre Deak wrote: > > By using the modifier plane capability flags to encode the modifiers' > > CCS type and tiling attributes, it becomes simpler to the check for > > any of these capabilities when providing the

Re: [Intel-gfx] [PATCH 3/3] drm/i915/fb: Fold modifier CCS type/tiling attribute to plane caps

2021-10-26 Thread Jani Nikula
On Tue, 26 Oct 2021, Imre Deak wrote: > By using the modifier plane capability flags to encode the modifiers' > CCS type and tiling attributes, it becomes simpler to the check for > any of these capabilities when providing the list of supported > modifiers. > > This also allows distinguishing

[Intel-gfx] [PATCH 3/3] drm/i915/fb: Fold modifier CCS type/tiling attribute to plane caps

2021-10-26 Thread Imre Deak
By using the modifier plane capability flags to encode the modifiers' CCS type and tiling attributes, it becomes simpler to the check for any of these capabilities when providing the list of supported modifiers. This also allows distinguishing modifiers on future platforms where platforms with