Re: [Intel-gfx] [PATCH 3/4] drm/i915: WaFbcDisableDpfcrClockGating only with fbc

2013-10-28 Thread Ben Widawsky
On Fri, Oct 25, 2013 at 03:14:50PM -0200, Paulo Zanoni wrote: 2013/10/24 Ben Widawsky benjamin.widaw...@intel.com: We were turning this on for ILK regardless of whether or not we use FBC. We can save the slightest amount of power if we don't disable it when not using FBC. Finally someone

Re: [Intel-gfx] [PATCH 3/4] drm/i915: WaFbcDisableDpfcrClockGating only with fbc

2013-10-25 Thread Paulo Zanoni
2013/10/24 Ben Widawsky benjamin.widaw...@intel.com: We were turning this on for ILK regardless of whether or not we use FBC. We can save the slightest amount of power if we don't disable it when not using FBC. Finally someone did what I requested months ago:

[Intel-gfx] [PATCH 3/4] drm/i915: WaFbcDisableDpfcrClockGating only with fbc

2013-10-24 Thread Ben Widawsky
We were turning this on for ILK regardless of whether or not we use FBC. We can save the slightest amount of power if we don't disable it when not using FBC. The workaround should be bit 8 for ILK. Notice it is 1 bit difference from SNB. This is actually DPFCR unit as we've defined it.