Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-05-20 Thread Jesse Barnes
On Fri, 16 May 2014 23:42:23 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, May 16, 2014 at 11:38:07PM +0100, Chris Wilson wrote: On Fri, May 16, 2014 at 03:20:47PM -0700, Jesse Barnes wrote: On Mon, 21 Apr 2014 18:37:31 +0200 Knut Petersen knut_peter...@t-online.de wrote:

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-05-20 Thread Jesse Barnes
On Tue, 20 May 2014 12:53:29 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri, 16 May 2014 23:42:23 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, May 16, 2014 at 11:38:07PM +0100, Chris Wilson wrote: On Fri, May 16, 2014 at 03:20:47PM -0700, Jesse Barnes wrote:

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-05-20 Thread Daniel Vetter
On Tue, May 20, 2014 at 9:58 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: Ah, poll_enable is false until after _thaw finishes, so our hotplug_resume call of hpd_irq_event does nothing. So aside from the encoder hot_plug callbacks (which really just check dp link status, which ought to be

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-05-20 Thread Jesse Barnes
On Tue, 20 May 2014 22:15:45 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: On Tue, May 20, 2014 at 9:58 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: Ah, poll_enable is false until after _thaw finishes, so our hotplug_resume call of hpd_irq_event does nothing. So aside from the

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-05-20 Thread Jesse Barnes
On Tue, 20 May 2014 14:10:16 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 20 May 2014 22:15:45 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: On Tue, May 20, 2014 at 9:58 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: Ah, poll_enable is false until after _thaw

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-05-20 Thread Jesse Barnes
On Tue, 20 May 2014 14:18:07 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 20 May 2014 14:10:16 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 20 May 2014 22:15:45 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: On Tue, May 20, 2014 at 9:58 PM, Jesse

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-05-16 Thread Jesse Barnes
On Mon, 21 Apr 2014 18:37:31 +0200 Knut Petersen knut_peter...@t-online.de wrote: + /* This driver doesn't need a VT switch to restore the mode on resume */ + info-skip_vt_switch = true; + drm_fb_helper_fill_fix(info, fb-pitches[0], fb-depth); drm_fb_helper_fill_var(info,

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-05-16 Thread Daniel Vetter
On Sat, May 17, 2014 at 12:20 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Mon, 21 Apr 2014 18:37:31 +0200 Knut Petersen knut_peter...@t-online.de wrote: + /* This driver doesn't need a VT switch to restore the mode on resume */ + info-skip_vt_switch = true; +

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-05-16 Thread Chris Wilson
On Fri, May 16, 2014 at 03:20:47PM -0700, Jesse Barnes wrote: On Mon, 21 Apr 2014 18:37:31 +0200 Knut Petersen knut_peter...@t-online.de wrote: + /* This driver doesn't need a VT switch to restore the mode on resume */ + info-skip_vt_switch = true; +

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-05-16 Thread Chris Wilson
On Fri, May 16, 2014 at 11:38:07PM +0100, Chris Wilson wrote: On Fri, May 16, 2014 at 03:20:47PM -0700, Jesse Barnes wrote: On Mon, 21 Apr 2014 18:37:31 +0200 Knut Petersen knut_peter...@t-online.de wrote: + /* This driver doesn't need a VT switch to restore the mode on resume

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2014-04-21 Thread Knut Petersen
On 26.03.2013 17:25, Jesse Barnes wrote: With the other bits in place, we can do this safely. v2: disable backlight on suspend to prevent premature enablement on resume v3: disable CRTCs on suspend to allow RTD3 (Kristen) Signed-off-by: Jesse Barnesjbar...@virtuousgeek.org I might be a bit

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2013-04-03 Thread Daniel Vetter
On Tue, Mar 26, 2013 at 09:25:45AM -0700, Jesse Barnes wrote: With the other bits in place, we can do this safely. v2: disable backlight on suspend to prevent premature enablement on resume v3: disable CRTCs on suspend to allow RTD3 (Kristen) Signed-off-by: Jesse Barnes

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2013-04-03 Thread Chris Wilson
On Wed, Apr 03, 2013 at 11:15:40AM +0200, Daniel Vetter wrote: On Tue, Mar 26, 2013 at 09:25:45AM -0700, Jesse Barnes wrote: With the other bits in place, we can do this safely. v2: disable backlight on suspend to prevent premature enablement on resume v3: disable CRTCs on suspend to

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2013-04-03 Thread Jesse Barnes
On Wed, 3 Apr 2013 11:54:23 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Wed, Apr 03, 2013 at 11:15:40AM +0200, Daniel Vetter wrote: On Tue, Mar 26, 2013 at 09:25:45AM -0700, Jesse Barnes wrote: With the other bits in place, we can do this safely. v2: disable backlight on

Re: [Intel-gfx] [PATCH 3/4] drm/i915: enable VT switchless resume v3

2013-03-26 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com On Tue, Mar 26, 2013 at 1:25 PM, Jesse Barnes jbar...@virtuousgeek.orgwrote: With the other bits in place, we can do this safely. v2: disable backlight on suspend to prevent premature enablement on resume v3: disable CRTCs on suspend to allow