Re: [Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-20 Thread Jani Nikula
On Fri, 16 Nov 2018, Chris Wilson wrote: > Quoting Jani Nikula (2018-11-15 12:01:24) >> No need to use a compound statement enclosed in parenthesis where a C99 >> compound literal will do. No functional changes. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/i915_fixed.h | 6

Re: [Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-16 Thread Jani Nikula
On Fri, 16 Nov 2018, Joonas Lahtinen wrote: > Quoting Jani Nikula (2018-11-15 14:01:24) >> No need to use a compound statement enclosed in parenthesis where a C99 >> compound literal will do. No functional changes. >> >> Signed-off-by: Jani Nikula > > Out of curiosity, did this have an effect

Re: [Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-16 Thread Chris Wilson
Quoting Jani Nikula (2018-11-15 12:01:24) > No need to use a compound statement enclosed in parenthesis where a C99 > compound literal will do. No functional changes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_fixed.h | 6 +- > 1 file changed, 1 insertion(+), 5

Re: [Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-16 Thread Joonas Lahtinen
Quoting Jani Nikula (2018-11-15 14:01:24) > No need to use a compound statement enclosed in parenthesis where a C99 > compound literal will do. No functional changes. > > Signed-off-by: Jani Nikula Out of curiosity, did this have an effect on asm generation? Presumably not. Reviewed-by: Joonas

[Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-15 Thread Jani Nikula
No need to use a compound statement enclosed in parenthesis where a C99 compound literal will do. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_fixed.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_fixed.h