Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Extract param logic form guc_init

2017-02-15 Thread Arkadiusz Hiler
On Wed, Feb 15, 2017 at 02:48:59PM +0200, Joonas Lahtinen wrote: > On ti, 2017-02-14 at 20:37 +0100, Michal Wajdeczko wrote: > > On Tue, Feb 14, 2017 at 05:15:39PM +0100, Arkadiusz Hiler wrote: > > > > > > Let intel_guc_init() focus on determining and fetching the correct > > > firmware. > > > >

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Extract param logic form guc_init

2017-02-15 Thread Joonas Lahtinen
On ti, 2017-02-14 at 20:37 +0100, Michal Wajdeczko wrote: > On Tue, Feb 14, 2017 at 05:15:39PM +0100, Arkadiusz Hiler wrote: > > > > Let intel_guc_init() focus on determining and fetching the correct > > firmware. > > > > This patch introduces intel_sanitize_uc_params() that is called from > >

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Extract param logic form guc_init

2017-02-14 Thread Michal Wajdeczko
On Tue, Feb 14, 2017 at 05:15:39PM +0100, Arkadiusz Hiler wrote: > Let intel_guc_init() focus on determining and fetching the correct > firmware. > > This patch introduces intel_sanitize_uc_params() that is called from > intel_uc_init(). > > Then, if we have GuC, we can call intel_guc_init()

[Intel-gfx] [PATCH 3/5] drm/i915/guc: Extract param logic form guc_init

2017-02-14 Thread Arkadiusz Hiler
Let intel_guc_init() focus on determining and fetching the correct firmware. This patch introduces intel_sanitize_uc_params() that is called from intel_uc_init(). Then, if we have GuC, we can call intel_guc_init() conditionally and we do not have to do internal checks. Cc: Michal Winiarski