Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-05-11 Thread Dixit, Ashutosh
On Wed, 11 May 2022 01:18:07 -0700, Tvrtko Ursulin wrote: > On 11/05/2022 06:26, Dixit, Ashutosh wrote: > > On Tue, 10 May 2022 00:43:29 -0700, Jani Nikula wrote: > >> On Tue, 10 May 2022, Tvrtko Ursulin wrote: > >>> On 29/04/2022 20:56, Ashutosh Dixit wrote: > diff --git

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-05-11 Thread Tvrtko Ursulin
On 11/05/2022 06:26, Dixit, Ashutosh wrote: On Tue, 10 May 2022 00:43:29 -0700, Jani Nikula wrote: On Tue, 10 May 2022, Tvrtko Ursulin wrote: On 29/04/2022 20:56, Ashutosh Dixit wrote: diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-05-10 Thread Dixit, Ashutosh
On Tue, 10 May 2022 00:43:29 -0700, Jani Nikula wrote: > On Tue, 10 May 2022, Tvrtko Ursulin wrote: > > On 29/04/2022 20:56, Ashutosh Dixit wrote: > >> diff --git a/drivers/gpu/drm/i915/i915_driver.c > >> b/drivers/gpu/drm/i915/i915_driver.c > >> index 90b0ce5051af..bc49eff38c6a 100644 > >> ---

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-05-10 Thread Jani Nikula
On Tue, 10 May 2022, Tvrtko Ursulin wrote: > On 29/04/2022 20:56, Ashutosh Dixit wrote: >> Each gt contains an independent instance of pcode. Extend pcode functions >> to interface with pcode on different gt's. To avoid creating dependency of >> display functionality on intel_gt, pcode function

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-05-10 Thread Tvrtko Ursulin
On 29/04/2022 20:56, Ashutosh Dixit wrote: Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. To avoid creating dependency of display functionality on intel_gt, pcode function interfaces are exposed in terms of uncore rather

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-05-10 Thread Andi Shyti
Hi Ashutosh, On Fri, Apr 29, 2022 at 12:56:24PM -0700, Ashutosh Dixit wrote: > Each gt contains an independent instance of pcode. Extend pcode functions > to interface with pcode on different gt's. To avoid creating dependency of > display functionality on intel_gt, pcode function interfaces are

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-05-02 Thread Rodrigo Vivi
On Fri, Apr 29, 2022 at 12:56:24PM -0700, Ashutosh Dixit wrote: > Each gt contains an independent instance of pcode. Extend pcode functions > to interface with pcode on different gt's. To avoid creating dependency of > display functionality on intel_gt, pcode function interfaces are exposed in >

[Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-29 Thread Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. To avoid creating dependency of display functionality on intel_gt, pcode function interfaces are exposed in terms of uncore rather than intel_gt. Callers have been converted to pass

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-26 Thread Jani Nikula
On Wed, 20 Apr 2022, "Vivi, Rodrigo" wrote: > On Tue, 2022-04-19 at 22:54 -0700, Dixit, Ashutosh wrote: >> On Fri, 15 Apr 2022 03:21:26 -0700, Rodrigo Vivi wrote: >> > On Thu, Apr 14, 2022 at 03:31:07PM -0700, Dixit, Ashutosh wrote: >> > > On Thu, 14 Apr 2022 06:28:57 -0700, Jani Nikula wrote: >>

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-20 Thread Vivi, Rodrigo
On Tue, 2022-04-19 at 22:54 -0700, Dixit, Ashutosh wrote: > On Fri, 15 Apr 2022 03:21:26 -0700, Rodrigo Vivi wrote: > > On Thu, Apr 14, 2022 at 03:31:07PM -0700, Dixit, Ashutosh wrote: > > > On Thu, 14 Apr 2022 06:28:57 -0700, Jani Nikula wrote: > > > > > > > > On Wed, 13 Apr 2022, Ashutosh Dixit

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-19 Thread Dixit, Ashutosh
On Fri, 15 Apr 2022 03:21:26 -0700, Rodrigo Vivi wrote: > On Thu, Apr 14, 2022 at 03:31:07PM -0700, Dixit, Ashutosh wrote: > > On Thu, 14 Apr 2022 06:28:57 -0700, Jani Nikula wrote: > > > > > > On Wed, 13 Apr 2022, Ashutosh Dixit wrote: > > > > Each gt contains an independent instance of pcode.

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-15 Thread Rodrigo Vivi
On Thu, Apr 14, 2022 at 03:31:07PM -0700, Dixit, Ashutosh wrote: > On Thu, 14 Apr 2022 06:28:57 -0700, Jani Nikula wrote: > > > > On Wed, 13 Apr 2022, Ashutosh Dixit wrote: > > > Each gt contains an independent instance of pcode. Extend pcode functions > > > to interface with pcode on different

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-14 Thread Dixit, Ashutosh
On Thu, 14 Apr 2022 06:28:57 -0700, Jani Nikula wrote: > > On Wed, 13 Apr 2022, Ashutosh Dixit wrote: > > Each gt contains an independent instance of pcode. Extend pcode functions > > to interface with pcode on different gt's. Previous (GT0) pcode read/write > > interfaces are preserved. > > The

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-14 Thread Jani Nikula
On Wed, 13 Apr 2022, Ashutosh Dixit wrote: > Each gt contains an independent instance of pcode. Extend pcode functions > to interface with pcode on different gt's. Previous (GT0) pcode read/write > interfaces are preserved. The big problem here is that this hard couples display code to gt code,

[Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-13 Thread Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. Previous (GT0) pcode read/write interfaces are preserved. Cc: Rodrigo Vivi Cc: Mike Ruhl Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/intel_pcode.c | 108