Re: [Intel-gfx] [PATCH 33/39] drm/i915/perf: add a parameter to control the size of OA buffer

2019-08-23 Thread Lucas De Marchi
On Fri, Aug 23, 2019 at 1:13 AM Lionel Landwerlin wrote: > > On 22/08/2019 12:43, Joonas Lahtinen wrote: > > Quoting Lucas De Marchi (2019-08-16 11:04:57) > >> From: Lionel Landwerlin > >> > >> The way our hardware is designed doesn't seem to let us use the > >> MI_RECORD_PERF_COUNT command

Re: [Intel-gfx] [PATCH 33/39] drm/i915/perf: add a parameter to control the size of OA buffer

2019-08-23 Thread Lionel Landwerlin
On 22/08/2019 12:43, Joonas Lahtinen wrote: Quoting Lucas De Marchi (2019-08-16 11:04:57) From: Lionel Landwerlin The way our hardware is designed doesn't seem to let us use the MI_RECORD_PERF_COUNT command without setting up a circular buffer. In the case where the user didn't request OA

Re: [Intel-gfx] [PATCH 33/39] drm/i915/perf: add a parameter to control the size of OA buffer

2019-08-22 Thread Joonas Lahtinen
Quoting Lucas De Marchi (2019-08-16 11:04:57) > From: Lionel Landwerlin > > The way our hardware is designed doesn't seem to let us use the > MI_RECORD_PERF_COUNT command without setting up a circular buffer. > > In the case where the user didn't request OA reports to be available > through the

Re: [Intel-gfx] [PATCH 33/39] drm/i915/perf: add a parameter to control the size of OA buffer

2019-08-21 Thread Lionel Landwerlin
I think this patch needs to be landed after https://patchwork.freedesktop.org/patch/319815/?series=60916=10 As recommended by Joonas. It should also bump the revision number of the perf API so that the application can detect this feature is available. Thanks, -Lionel On 16/08/2019 10:04,

Re: [Intel-gfx] [PATCH 33/39] drm/i915/perf: add a parameter to control the size of OA buffer

2019-08-19 Thread Umesh Nerlige Ramappa
Looks good. Reviewed-by: Umesh Nerlige Ramappa On Fri, Aug 16, 2019 at 01:04:57AM -0700, Lucas De Marchi wrote: From: Lionel Landwerlin The way our hardware is designed doesn't seem to let us use the MI_RECORD_PERF_COUNT command without setting up a circular buffer. In the case where the

[Intel-gfx] [PATCH 33/39] drm/i915/perf: add a parameter to control the size of OA buffer

2019-08-16 Thread Lucas De Marchi
From: Lionel Landwerlin The way our hardware is designed doesn't seem to let us use the MI_RECORD_PERF_COUNT command without setting up a circular buffer. In the case where the user didn't request OA reports to be available through the i915 perf stream, we can set the OA buffer to the minimum