Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-07-04 Thread Mauro Carvalho Chehab
On Fri, 1 Jul 2022 08:56:53 +0100 Tvrtko Ursulin wrote: > On 30/06/2022 17:01, Mauro Carvalho Chehab wrote: > > Em Thu, 30 Jun 2022 09:12:41 +0100 > > Tvrtko Ursulin escreveu: > > > >> On 30/06/2022 08:32, Mauro Carvalho Chehab wrote: > >>> Em Wed, 29 Jun 2022 17:02:59 +0100 > >>> Tvrtko

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-07-01 Thread Tvrtko Ursulin
On 30/06/2022 17:01, Mauro Carvalho Chehab wrote: Em Thu, 30 Jun 2022 09:12:41 +0100 Tvrtko Ursulin escreveu: On 30/06/2022 08:32, Mauro Carvalho Chehab wrote: Em Wed, 29 Jun 2022 17:02:59 +0100 Tvrtko Ursulin escreveu: On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: On Tue, 28

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-30 Thread Mauro Carvalho Chehab
Em Thu, 30 Jun 2022 09:12:41 +0100 Tvrtko Ursulin escreveu: > On 30/06/2022 08:32, Mauro Carvalho Chehab wrote: > > Em Wed, 29 Jun 2022 17:02:59 +0100 > > Tvrtko Ursulin escreveu: > > > >> On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: > >>> On Tue, 28 Jun 2022 16:49:23 +0100 > >>>

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-30 Thread Tvrtko Ursulin
On 30/06/2022 08:32, Mauro Carvalho Chehab wrote: Em Wed, 29 Jun 2022 17:02:59 +0100 Tvrtko Ursulin escreveu: On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: On Tue, 28 Jun 2022 16:49:23 +0100 Tvrtko Ursulin wrote: .. which for me means a different patch 1, followed by patch 6

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-30 Thread Mauro Carvalho Chehab
Em Wed, 29 Jun 2022 17:02:59 +0100 Tvrtko Ursulin escreveu: > On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: > > On Tue, 28 Jun 2022 16:49:23 +0100 > > Tvrtko Ursulin wrote: > > > >> .. which for me means a different patch 1, followed by patch 6 (moved > >> to be patch 2) would be ideal

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-29 Thread Tvrtko Ursulin
On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: On Tue, 28 Jun 2022 16:49:23 +0100 Tvrtko Ursulin wrote: .. which for me means a different patch 1, followed by patch 6 (moved to be patch 2) would be ideal stable material. Then we have the current patch 2 which is open/unknown (to me at

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-29 Thread Mauro Carvalho Chehab
On Tue, 28 Jun 2022 16:49:23 +0100 Tvrtko Ursulin wrote: >.. which for me means a different patch 1, followed by patch 6 (moved > to be patch 2) would be ideal stable material. > > Then we have the current patch 2 which is open/unknown (to me at least). > > And the rest seem like

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-28 Thread Tvrtko Ursulin
Hi, On 27/06/2022 10:00, Mauro Carvalho Chehab (by way of Mauro Carvalho Chehab ) wrote: Hi Tvrtko, On Fri, 24 Jun 2022 09:34:21 +0100 Tvrtko Ursulin wrote: On 23/06/2022 12:17, Andi Shyti wrote: Hi Mauro, On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: From:

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-28 Thread Mauro Carvalho Chehab
Hi Tvrtko, On Fri, 24 Jun 2022 09:34:21 +0100 Tvrtko Ursulin wrote: > On 23/06/2022 12:17, Andi Shyti wrote: > > Hi Mauro, > > > > On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: > >> From: Chris Wilson > >> > >> Don't allow two engines to be reset in parallel, as

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-24 Thread Tvrtko Ursulin
On 23/06/2022 12:17, Andi Shyti wrote: Hi Mauro, On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: From: Chris Wilson Don't allow two engines to be reset in parallel, as they would both try to select a reset bit (and send requests to common registers) and wait on that

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-23 Thread Andi Shyti
Hi Mauro, On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Don't allow two engines to be reset in parallel, as they would both > try to select a reset bit (and send requests to common registers) > and wait on that register, at the same time.

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-16 Thread Tvrtko Ursulin
On 15/06/2022 16:27, Mauro Carvalho Chehab wrote: From: Chris Wilson Don't allow two engines to be reset in parallel, as they would both try to select a reset bit (and send requests to common registers) and wait on that register, at the same time. Serialize control of the reset requests/acks

[Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-15 Thread Mauro Carvalho Chehab
From: Chris Wilson Don't allow two engines to be reset in parallel, as they would both try to select a reset bit (and send requests to common registers) and wait on that register, at the same time. Serialize control of the reset requests/acks using the uncore->lock, which will also ensure that