Re: [Intel-gfx] [PATCH 5/8] drm/i915/uc: Make intel_uc_fw_fetch() static

2017-02-22 Thread Arkadiusz Hiler
On Wed, Feb 22, 2017 at 04:17:20PM +0200, Joonas Lahtinen wrote: > On ke, 2017-02-22 at 13:41 +0100, Arkadiusz Hiler wrote: > > intel_uc_fw_fetch() is confusingly named in the light of recent changes. > > > > It's also in the wrong place - 'guc_loader.h' - it's used for both guc > > and huc,

Re: [Intel-gfx] [PATCH 5/8] drm/i915/uc: Make intel_uc_fw_fetch() static

2017-02-22 Thread Joonas Lahtinen
On ke, 2017-02-22 at 13:41 +0100, Arkadiusz Hiler wrote: > intel_uc_fw_fetch() is confusingly named in the light of recent changes. > > It's also in the wrong place - 'guc_loader.h' - it's used for both guc > and huc, which was reflected in name, but not it's location, so let's > move it to

[Intel-gfx] [PATCH 5/8] drm/i915/uc: Make intel_uc_fw_fetch() static

2017-02-22 Thread Arkadiusz Hiler
intel_uc_fw_fetch() is confusingly named in the light of recent changes. It's also in the wrong place - 'guc_loader.h' - it's used for both guc and huc, which was reflected in name, but not it's location, so let's move it to 'intel_uc.c'. We can make a intel_uc_fw callback out of it, to avoid

Re: [Intel-gfx] [PATCH 5/8] drm/i915/uc: Make intel_uc_fw_fetch() static

2017-02-21 Thread Arkadiusz Hiler
On Fri, Feb 17, 2017 at 02:39:35PM +0100, Michal Wajdeczko wrote: > On Fri, Feb 17, 2017 at 02:05:54PM +0100, Arkadiusz Hiler wrote: > > intel_uc_fw_fetch() is confusingly named in the light of recent changes. > > > > It's also in the worng place - 'guc_loader.h' - it's used for both guc > >

Re: [Intel-gfx] [PATCH 5/8] drm/i915/uc: Make intel_uc_fw_fetch() static

2017-02-17 Thread Michal Wajdeczko
On Fri, Feb 17, 2017 at 02:05:54PM +0100, Arkadiusz Hiler wrote: > intel_uc_fw_fetch() is confusingly named in the light of recent changes. > > It's also in the worng place - 'guc_loader.h' - it's used for both guc Typo s/worng/wrong > and huc, which was reflected in name, but not it's

[Intel-gfx] [PATCH 5/8] drm/i915/uc: Make intel_uc_fw_fetch() static

2017-02-17 Thread Arkadiusz Hiler
intel_uc_fw_fetch() is confusingly named in the light of recent changes. It's also in the worng place - 'guc_loader.h' - it's used for both guc and huc, which was reflected in name, but not it's location, so let's move it to 'intel_uc.c'. We can make a intel_uc_fw callback out of it, to avoid