Re: [Intel-gfx] [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

2019-10-29 Thread Daniele Ceraolo Spurio
On 10/29/19 2:51 PM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-10-29 21:46:46) On 10/29/19 2:58 AM, Matthew Auld wrote: Since we have no way access it from the CPU. For such cases just fallback to internal objects. Since the problem is not limited to rings but it applies t

Re: [Intel-gfx] [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

2019-10-29 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-10-29 21:46:46) > > > On 10/29/19 2:58 AM, Matthew Auld wrote: > > Since we have no way access it from the CPU. For such cases just > > fallback to internal objects. > > > > Since the problem is not limited to rings but it applies to all stolen > objects, w

Re: [Intel-gfx] [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

2019-10-29 Thread Daniele Ceraolo Spurio
On 10/29/19 2:58 AM, Matthew Auld wrote: Since we have no way access it from the CPU. For such cases just fallback to internal objects. Since the problem is not limited to rings but it applies to all stolen objects, wouldn't it be better to just skip the stolen initialization or return an

Re: [Intel-gfx] [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

2019-10-29 Thread Chris Wilson
Quoting Matthew Auld (2019-10-29 09:58:55) > Since we have no way access it from the CPU. For such cases just > fallback to internal objects. > > Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list Intel-gfx@lists.fr

[Intel-gfx] [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

2019-10-29 Thread Matthew Auld
Since we have no way access it from the CPU. For such cases just fallback to internal objects. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gt/intel_ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/