Re: [Intel-gfx] [PATCH i-g-t] i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry

2020-02-24 Thread Chris Wilson
Quoting Martin Peres (2020-02-24 09:16:02) > On 2020-02-21 15:56, Chris Wilson wrote: > > Since we check before and then after each debugfs entry, we do not need > > to check before each time as well. We will error out as soon as it does > > fail, at all other times we know the system to be idle.

Re: [Intel-gfx] [PATCH i-g-t] i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry

2020-02-24 Thread Martin Peres
On 2020-02-21 15:56, Chris Wilson wrote: > Since we check before and then after each debugfs entry, we do not need > to check before each time as well. We will error out as soon as it does > fail, at all other times we know the system to be idle. > > No impact on runtime for glk (which apparently

[Intel-gfx] [PATCH i-g-t] i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry

2020-02-21 Thread Chris Wilson
Since we check before and then after each debugfs entry, we do not need to check before each time as well. We will error out as soon as it does fail, at all other times we know the system to be idle. No impact on runtime for glk (which apparently is one of the better behaving systems). v2:

Re: [Intel-gfx] [PATCH i-g-t] i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry

2020-02-21 Thread Chris Wilson
Quoting Martin Peres (2020-02-21 08:28:16) > On 2020-02-21 10:21, Chris Wilson wrote: > > Quoting Martin Peres (2020-02-21 07:33:59) > >> On 2020-02-20 19:41, Chris Wilson wrote: > >>> Since we check before and then after each debugfs entry, we do not need > >>> to check before each time as well.

Re: [Intel-gfx] [PATCH i-g-t] i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry

2020-02-21 Thread Martin Peres
On 2020-02-21 10:21, Chris Wilson wrote: > Quoting Martin Peres (2020-02-21 07:33:59) >> On 2020-02-20 19:41, Chris Wilson wrote: >>> Since we check before and then after each debugfs entry, we do not need >>> to check before each time as well. We will error out as soon as it does >>> fail, at all

Re: [Intel-gfx] [PATCH i-g-t] i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry

2020-02-21 Thread Chris Wilson
Quoting Martin Peres (2020-02-21 07:33:59) > On 2020-02-20 19:41, Chris Wilson wrote: > > Since we check before and then after each debugfs entry, we do not need > > to check before each time as well. We will error out as soon as it does > > fail, at all other times we know the system to be idle.

Re: [Intel-gfx] [PATCH i-g-t] i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry

2020-02-20 Thread Martin Peres
On 2020-02-20 19:41, Chris Wilson wrote: > Since we check before and then after each debugfs entry, we do not need > to check before each time as well. We will error out as soon as it does > fail, at all other times we know the system to be idle. > > No impact on runtime for glk (which apparently

[Intel-gfx] [PATCH i-g-t] i915/i915_pm_rpm: Only check for suspend failures after each debugfs entry

2020-02-20 Thread Chris Wilson
Since we check before and then after each debugfs entry, we do not need to check before each time as well. We will error out as soon as it does fail, at all other times we know the system to be idle. No impact on runtime for glk (which apparently is one of the better behaving systems).