Re: [Intel-gfx] [PATCH i-g-t] lib/draw: Align mmap requests to page boundaries

2019-01-23 Thread Chris Wilson
Quoting Joonas Lahtinen (2019-01-23 14:22:54) > Quoting Chris Wilson (2019-01-07 12:56:36) > > Since we trust fb->size as either calculated by calc_fb_size() or the > > supplied by the user, it invariably isn't page aligned. The mmap > > routines and ioctls only deal in pages... > > > > Not sure

Re: [Intel-gfx] [PATCH i-g-t] lib/draw: Align mmap requests to page boundaries

2019-01-23 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-01-07 12:56:36) > Since we trust fb->size as either calculated by calc_fb_size() or the > supplied by the user, it invariably isn't page aligned. The mmap > routines and ioctls only deal in pages... > > Not sure if fb->size should be page aligned, but that may break >

[Intel-gfx] [PATCH i-g-t] lib/draw: Align mmap requests to page boundaries

2019-01-07 Thread Chris Wilson
Since we trust fb->size as either calculated by calc_fb_size() or the supplied by the user, it invariably isn't page aligned. The mmap routines and ioctls only deal in pages... Not sure if fb->size should be page aligned, but that may break some other drawing tests, so opt to just fix up the mmap