Re: [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

2018-07-10 Thread Chris Wilson
Quoting Mika Kuoppala (2018-07-10 14:30:15) > Chris Wilson writes: > > > As we ordinarily use a spinning batch to trigger a hang, we cannot do so > > without execbuf. On the other hand, if we do a manual reset of the > > wedged driver, we expect it to remain wedged and for the reset to fail; > >

Re: [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

2018-07-10 Thread Mika Kuoppala
Chris Wilson writes: > As we ordinarily use a spinning batch to trigger a hang, we cannot do so > without execbuf. On the other hand, if we do a manual reset of the > wedged driver, we expect it to remain wedged and for the reset to fail; > failing the test. Even if we remove the

Re: [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

2018-07-10 Thread Chris Wilson
Quoting Mika Kuoppala (2018-07-10 14:13:39) > Chris Wilson writes: > > > As we ordinarily use a spinning batch to trigger a hang, we cannot do so > > without execbuf. On the other hand, if we do a manual reset of the > > wedged driver, we expect it to remain wedged and for the reset to fail; >

Re: [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

2018-07-10 Thread Mika Kuoppala
Chris Wilson writes: > As we ordinarily use a spinning batch to trigger a hang, we cannot do so > without execbuf. On the other hand, if we do a manual reset of the > wedged driver, we expect it to remain wedged and for the reset to fail; by 'manual' you are referring to '-1' on i915_wedged

[Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

2018-07-10 Thread Chris Wilson
As we ordinarily use a spinning batch to trigger a hang, we cannot do so without execbuf. On the other hand, if we do a manual reset of the wedged driver, we expect it to remain wedged and for the reset to fail; failing the test. Even if we remove the igt_assert(!wedged), the test is suspect as we