Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Don't use rmmod exit code when reloading the module.

2016-05-24 Thread Daniel Vetter
On Tue, May 24, 2016 at 09:03:19AM +0100, Chris Wilson wrote: > On Tue, May 24, 2016 at 09:55:26AM +0200, Daniel Vetter wrote: > > On Mon, May 23, 2016 at 01:43:42PM +0300, Marius Vlad wrote: > > > On Fri, May 20, 2016 at 05:23:56PM +0100, Chris Wilson wrote: > > > > On Fri, May 20, 2016 at

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Don't use rmmod exit code when reloading the module.

2016-05-24 Thread Chris Wilson
On Tue, May 24, 2016 at 09:03:19AM +0100, Chris Wilson wrote: > On Tue, May 24, 2016 at 09:55:26AM +0200, Daniel Vetter wrote: > > On Mon, May 23, 2016 at 01:43:42PM +0300, Marius Vlad wrote: > > > On Fri, May 20, 2016 at 05:23:56PM +0100, Chris Wilson wrote: > > > > On Fri, May 20, 2016 at

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Don't use rmmod exit code when reloading the module.

2016-05-24 Thread Chris Wilson
On Tue, May 24, 2016 at 09:55:26AM +0200, Daniel Vetter wrote: > On Mon, May 23, 2016 at 01:43:42PM +0300, Marius Vlad wrote: > > On Fri, May 20, 2016 at 05:23:56PM +0100, Chris Wilson wrote: > > > On Fri, May 20, 2016 at 07:00:18PM +0300, Imre Deak wrote: > > > > On pe, 2016-05-20 at 18:20 +0300,

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Don't use rmmod exit code when reloading the module.

2016-05-24 Thread Daniel Vetter
On Mon, May 23, 2016 at 01:43:42PM +0300, Marius Vlad wrote: > On Fri, May 20, 2016 at 05:23:56PM +0100, Chris Wilson wrote: > > On Fri, May 20, 2016 at 07:00:18PM +0300, Imre Deak wrote: > > > On pe, 2016-05-20 at 18:20 +0300, Marius Vlad wrote: > > > > Either we return $IGT_EXIT_FAILURE or

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Don't use rmmod exit code when reloading the module.

2016-05-23 Thread Marius Vlad
On Fri, May 20, 2016 at 05:23:56PM +0100, Chris Wilson wrote: > On Fri, May 20, 2016 at 07:00:18PM +0300, Imre Deak wrote: > > On pe, 2016-05-20 at 18:20 +0300, Marius Vlad wrote: > > > Either we return $IGT_EXIT_FAILURE or remove it entirely (like in > > > this > > > patch). If rmmod returns

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Don't use rmmod exit code when reloading the module.

2016-05-20 Thread Imre Deak
On pe, 2016-05-20 at 17:23 +0100, Chris Wilson wrote: > On Fri, May 20, 2016 at 07:00:18PM +0300, Imre Deak wrote: > > On pe, 2016-05-20 at 18:20 +0300, Marius Vlad wrote: > > > Either we return $IGT_EXIT_FAILURE or remove it entirely (like in > > > this > > > patch). If rmmod returns non-zero

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Don't use rmmod exit code when reloading the module.

2016-05-20 Thread Chris Wilson
On Fri, May 20, 2016 at 07:00:18PM +0300, Imre Deak wrote: > On pe, 2016-05-20 at 18:20 +0300, Marius Vlad wrote: > > Either we return $IGT_EXIT_FAILURE or remove it entirely (like in > > this > > patch). If rmmod returns non-zero (i.e., Module: i915 is still in > > use), reload > > will bail with

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Don't use rmmod exit code when reloading the module.

2016-05-20 Thread Imre Deak
On pe, 2016-05-20 at 18:20 +0300, Marius Vlad wrote: > Either we return $IGT_EXIT_FAILURE or remove it entirely (like in > this > patch). If rmmod returns non-zero (i.e., Module: i915 is still in > use), reload > will bail with $IGT_EXIT_SKIP, making the check with lsmod useless. > Also use the

[Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Don't use rmmod exit code when reloading the module.

2016-05-20 Thread Marius Vlad
Either we return $IGT_EXIT_FAILURE or remove it entirely (like in this patch). If rmmod returns non-zero (i.e., Module: i915 is still in use), reload will bail with $IGT_EXIT_SKIP, making the check with lsmod useless. Also use the return value in the fault-injection loop. Signed-off-by: Marius