Re: [Intel-gfx] [PATCH i-g-t] tests/kms_chamelium: Make tests run without pipe color management support.

[Maarten Lankhorst]

Op 09-03-18 om 14:08 schreef Maxime Ripard:
> On Fri, Mar 09, 2018 at 12:55:24PM +0100, Maarten Lankhorst wrote:
>> Op 06-03-18 om 16:57 schreef Maxime Ripard:
>>> Hi,
>>>
>>> On Mon, Mar 05, 2018 at 07:14:16PM +0100, Maarten Lankhorst wrote:
 Only try to set those values if the properties are supported.
 This fixes the kms_chameium tests to run on vc4 again.

 Reported-by: Maxime Ripard 
 Cc: Paul Kocialkowski 
 Cc: Eric Anholt 
 Cc: Boris Brezillon 
 Signed-off-by: Maarten Lankhorst 
>>> This works like a charm now, thanks!
>>> Tested-by: Maxime Ripard 
>>>
>>> Maxime
>>>
>> Can you upgrade this to a reviewed-by so I can apply this change?
> Yep, of course:
> Reviewed-by: Maxime Ripard 
>
Thanks, pushed.

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_chamelium: Make tests run without pipe color management support.

[Maxime Ripard]

On Fri, Mar 09, 2018 at 12:55:24PM +0100, Maarten Lankhorst wrote:
> Op 06-03-18 om 16:57 schreef Maxime Ripard:
> > Hi,
> >
> > On Mon, Mar 05, 2018 at 07:14:16PM +0100, Maarten Lankhorst wrote:
> >> Only try to set those values if the properties are supported.
> >> This fixes the kms_chameium tests to run on vc4 again.
> >>
> >> Reported-by: Maxime Ripard 
> >> Cc: Paul Kocialkowski 
> >> Cc: Eric Anholt 
> >> Cc: Boris Brezillon 
> >> Signed-off-by: Maarten Lankhorst 
> > This works like a charm now, thanks!
> > Tested-by: Maxime Ripard 
> >
> > Maxime
> >
> Can you upgrade this to a reviewed-by so I can apply this change?

Yep, of course:
Reviewed-by: Maxime Ripard 

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_chamelium: Make tests run without pipe color management support.

[Maarten Lankhorst]

Op 06-03-18 om 16:57 schreef Maxime Ripard:
> Hi,
>
> On Mon, Mar 05, 2018 at 07:14:16PM +0100, Maarten Lankhorst wrote:
>> Only try to set those values if the properties are supported.
>> This fixes the kms_chameium tests to run on vc4 again.
>>
>> Reported-by: Maxime Ripard 
>> Cc: Paul Kocialkowski 
>> Cc: Eric Anholt 
>> Cc: Boris Brezillon 
>> Signed-off-by: Maarten Lankhorst 
> This works like a charm now, thanks!
> Tested-by: Maxime Ripard 
>
> Maxime
>
Can you upgrade this to a reviewed-by so I can apply this change?

~Maarten

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_chamelium: Make tests run without pipe color management support.

[Maxime Ripard]

Hi,

On Mon, Mar 05, 2018 at 07:14:16PM +0100, Maarten Lankhorst wrote:
> Only try to set those values if the properties are supported.
> This fixes the kms_chameium tests to run on vc4 again.
> 
> Reported-by: Maxime Ripard 
> Cc: Paul Kocialkowski 
> Cc: Eric Anholt 
> Cc: Boris Brezillon 
> Signed-off-by: Maarten Lankhorst 

This works like a charm now, thanks!
Tested-by: Maxime Ripard 

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] tests/kms_chamelium: Make tests run without pipe color management support.

[Maarten Lankhorst]

Only try to set those values if the properties are supported.
This fixes the kms_chameium tests to run on vc4 again.

Reported-by: Maxime Ripard 
Cc: Paul Kocialkowski 
Cc: Eric Anholt 
Cc: Boris Brezillon 
Signed-off-by: Maarten Lankhorst 
---
 tests/kms_chamelium.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index 8855a8300049..2bc34d07788d 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -471,9 +471,12 @@ enable_output(data_t *data,
igt_output_override_mode(output, mode);
 
/* Clear any color correction values that might be enabled */
-   igt_pipe_obj_replace_prop_blob(primary->pipe, IGT_CRTC_DEGAMMA_LUT, 
NULL, 0);
-   igt_pipe_obj_replace_prop_blob(primary->pipe, IGT_CRTC_GAMMA_LUT, NULL, 
0);
-   igt_pipe_obj_replace_prop_blob(primary->pipe, IGT_CRTC_CTM, NULL, 0);
+   if (igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_DEGAMMA_LUT))
+   igt_pipe_obj_replace_prop_blob(primary->pipe, 
IGT_CRTC_DEGAMMA_LUT, NULL, 0);
+   if (igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_GAMMA_LUT))
+   igt_pipe_obj_replace_prop_blob(primary->pipe, 
IGT_CRTC_GAMMA_LUT, NULL, 0);
+   if (igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_CTM))
+   igt_pipe_obj_replace_prop_blob(primary->pipe, IGT_CRTC_CTM, 
NULL, 0);
 
igt_display_commit2(display, COMMIT_ATOMIC);
 
-- 
2.16.2

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx