Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

On Mon, Sep 04, 2017 at 03:09:10PM -0300, Paulo Zanoni wrote: > Em Seg, 2017-09-04 às 10:00 +0200, Daniel Vetter escreveu: > > On Fri, Sep 01, 2017 at 04:44:38PM -0300, Paulo Zanoni wrote: > > > Em Seg, 2017-08-14 às 11:25 +0200, Daniel Vetter escreveu: > > > > Macros that should be C functions

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

Em Seg, 2017-09-04 às 10:00 +0200, Daniel Vetter escreveu: > On Fri, Sep 01, 2017 at 04:44:38PM -0300, Paulo Zanoni wrote: > > Em Seg, 2017-08-14 às 11:25 +0200, Daniel Vetter escreveu: > > > Macros that should be C functions but aren't are really hard to > > > read and confusing. Convert them

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

On Fri, Sep 01, 2017 at 04:44:38PM -0300, Paulo Zanoni wrote: > Em Seg, 2017-08-14 às 11:25 +0200, Daniel Vetter escreveu: > > Macros that should be C functions but aren't are really hard to > > read and confusing. Convert them over. > > > > v2: Clean up commit message and keep printing the line

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

Em Seg, 2017-08-14 às 11:25 +0200, Daniel Vetter escreveu: > Macros that should be C functions but aren't are really hard to > read and confusing. Convert them over. > > v2: Clean up commit message and keep printing the line numbers > (Paulo). > > v3: Actually git add (silly me). > > Cc: Paulo

[Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

Macros that should be C functions but aren't are really hard to read and confusing. Convert them over. v2: Clean up commit message and keep printing the line numbers (Paulo). v3: Actually git add (silly me). Cc: Paulo Zanoni Signed-off-by: Daniel Vetter

[Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

Macros that should be C functions but aren't are really hard to read and confusing. Convert them over. v2: Clean up commit message and keep printing the line numbers (Paulo). Cc: Paulo Zanoni Signed-off-by: Daniel Vetter ---

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

On Fri, Aug 04, 2017 at 03:30:30PM -0300, Paulo Zanoni wrote: > Em Sex, 2017-08-04 às 18:21 +0200, Daniel Vetter escreveu: > > I guess this was done to have a better indication of which testcase > > and function failed, but igt nowadays dumps an entire stacktrace. > > But we may have multiple

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

Em Sex, 2017-08-04 às 18:21 +0200, Daniel Vetter escreveu: > I guess this was done to have a better indication of which testcase > and function failed, but igt nowadays dumps an entire stacktrace. But we may have multiple do_assertions() calls in a single function. > And > macros of this

[Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

I guess this was done to have a better indication of which testcase and function failed, but igt nowadays dumps an entire stacktrace. And macros of this magnitude mean the line number is entirely meaningless, since it doesn't point at a specific check. Reason I've started to looking into this is