Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Mika Kahola
On Wed, 2017-08-02 at 15:42 +0300, Petri Latvala wrote: > After a bit of digging into this n_words conundrum that I also could > not understand, I found the issue Mika described. > > kms_plane_multiple et al basically do > > igt_crc_t crc; > > > and then they pass to test-internal helper

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Petri Latvala
After a bit of digging into this n_words conundrum that I also could not understand, I found the issue Mika described. kms_plane_multiple et al basically do igt_crc_t crc; and then they pass to test-internal helper functions, which pass the igt_crc_t* pointer to various igt lib functions.

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Mika Kahola
> Behalf Of > > > > > Daniel Vetter > > > > > Sent: Monday, July 31, 2017 11:13 AM > > > > > To: Kahola, Mika <mika.kah...@intel.com> > > > > > Cc: intel-gfx <intel-gfx@lists.freedesktop.org> > > &g

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Daniel Vetter
t; > > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On >> > > Behalf Of >> > > Daniel Vetter >> > > Sent: Monday, July 31, 2017 11:13 AM >> > > To: Kahola, Mika <mika.kah...@intel.com> >> > > Cc: intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Mika Kahola
t; > > Daniel Vetter > > > Sent: Monday, July 31, 2017 11:13 AM > > > To: Kahola, Mika <mika.kah...@intel.com> > > > Cc: intel-gfx <intel-gfx@lists.freedesktop.org> > > > Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: > &

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Lofstedt, Marta
edesktop.org> > Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix > reference CRC > > On Mon, Jul 31, 2017 at 09:04:50AM +, Kahola, Mika wrote: > > > -Original Message- > > > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Daniel Vetter
h...@intel.com> > > Cc: intel-gfx <intel-gfx@lists.freedesktop.org> > > Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix > > reference > > CRC > > > > On Fri, Jul 28, 2017 at 2:45 PM, Mika Kahola <mika.kah...@intel.com> wrote: >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-07-31 Thread Kahola, Mika
> -Original Message- > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > Daniel Vetter > Sent: Monday, July 31, 2017 11:13 AM > To: Kahola, Mika <mika.kah...@intel.com> > Cc: intel-gfx <intel-gfx@lists.freedesktop.org> > Subj

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-07-31 Thread Daniel Vetter
On Fri, Jul 28, 2017 at 2:45 PM, Mika Kahola wrote: > When grabbing reference CRC with igt_pipe_crc_get_crcs() the number of > words in igt_crc_t structure was incorrectly collected. The fix here is > to switch to igt_pipe_crc_collect_crc() function when collecting CRC for

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-07-28 Thread Mika Kahola
When grabbing reference CRC with igt_pipe_crc_get_crcs() the number of words in igt_crc_t structure was incorrectly collected. The fix here is to switch to igt_pipe_crc_collect_crc() function when collecting CRC for reference frame. The problem was caught by CI system and at least affects on HSW