Re: [Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Add option to hide inactive clients

2021-02-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-01 10:45:23)
> From: Tvrtko Ursulin 
> 
> Allow hiding inactive clients (used no GPU time ever) in interactive mode
> by pressing 'i'.
> 
> Signed-off-by: Tvrtko Ursulin 

Ok, that's where you meant. Coffee not winning the battle today.

Reviewed-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Add option to hide inactive clients

2021-02-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin 

Allow hiding inactive clients (used no GPU time ever) in interactive mode
by pressing 'i'.

Signed-off-by: Tvrtko Ursulin 
---
 man/intel_gpu_top.rst | 1 +
 tools/intel_gpu_top.c | 7 +++
 2 files changed, 8 insertions(+)

diff --git a/man/intel_gpu_top.rst b/man/intel_gpu_top.rst
index b18fd9675bb7..118d8b953a70 100644
--- a/man/intel_gpu_top.rst
+++ b/man/intel_gpu_top.rst
@@ -57,6 +57,7 @@ Supported keys:
 '1'Toggle between aggregated engine class and physical engine mode.
 'n'Toggle display of numeric client busyness overlay.
 's'Toggle between sort modes (runtime, total runtime, client id).
+'i'Toggle display of clients which used no GPU time.
 
 DEVICE SELECTION
 
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 60ff62d28e5d..dffc6ebecc57 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1933,6 +1933,7 @@ print_clients_header(struct clients *clients, int lines,
 }
 
 static bool numeric_clients;
+static bool filter_idle;
 
 static int
 print_client(struct client *c, struct engines *engines, double t, int lines,
@@ -1942,6 +1943,9 @@ print_client(struct client *c, struct engines *engines, 
double t, int lines,
unsigned int i;
 
if (output_mode == INTERACTIVE) {
+   if (filter_idle && !c->total_runtime)
+   return lines;
+
lines++;
 
printf("%6u %17s ", c->pid, c->print_name);
@@ -2118,6 +2122,9 @@ static void process_stdin(unsigned int timeout_us)
case '1':
class_view ^= true;
break;
+   case 'i':
+   filter_idle ^= true;
+   break;
case 'n':
numeric_clients ^= true;
break;
-- 
2.27.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx