Re: [Intel-gfx] [PATCH v10 3/7] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-02-14 Thread Yaodong Li
On 02/14/2018 09:38 AM, Michal Wajdeczko wrote: On Wed, 14 Feb 2018 03:26:12 +0100, Yaodong Li wrote: On 02/13/2018 07:56 AM, Michal Wajdeczko wrote: Also, comparing again your drawing with the spec I think it should look like this:    +

Re: [Intel-gfx] [PATCH v10 3/7] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-02-14 Thread Michal Wajdeczko
On Wed, 14 Feb 2018 03:26:12 +0100, Yaodong Li wrote: On 02/13/2018 07:56 AM, Michal Wajdeczko wrote: Also, comparing again your drawing with the spec I think it should look like this: + ++ <== WOPCM top /|\| HW RESERVED

Re: [Intel-gfx] [PATCH v10 3/7] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-02-13 Thread Yaodong Li
On 02/13/2018 07:56 AM, Michal Wajdeczko wrote: Also, comparing again your drawing with the spec I think it should look like this:    + ++ <== WOPCM top   /|\    | HW RESERVED    |    | +--- +    | |    |    | 

Re: [Intel-gfx] [PATCH v10 3/7] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-02-13 Thread Michal Wajdeczko
On Tue, 13 Feb 2018 21:01:04 +0100, Yaodong Li wrote: On 02/13/2018 07:56 AM, Michal Wajdeczko wrote: + +/* GUC WOPCM offset needs to be 16KB aligned. */ +#define GUC_WOPCM_OFFSET_ALIGNMENT(16 << 10) +/* 16KB reserved at the beginning of GuC WOPCM. */ +#define

Re: [Intel-gfx] [PATCH v10 3/7] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-02-13 Thread Yaodong Li
On 02/13/2018 07:56 AM, Michal Wajdeczko wrote: + +/* GUC WOPCM offset needs to be 16KB aligned. */ +#define GUC_WOPCM_OFFSET_ALIGNMENT    (16 << 10) +/* 16KB reserved at the beginning of GuC WOPCM. */ +#define GUC_WOPCM_RESERVED    (16 << 10) +/* 8KB from GUC_WOPCM_RESERVED is reserved for

Re: [Intel-gfx] [PATCH v10 3/7] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-02-13 Thread Michal Wajdeczko
On Tue, 13 Feb 2018 00:45:49 +0100, Jackie Li wrote: Hardware may have specific restrictions on GuC WOPCM offset and size. On Gen9, the value of the GuC WOPCM size register needs to be larger than the value of GuC WOPCM offset register + a Gen9 specific offset (144KB)

[Intel-gfx] [PATCH v10 3/7] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-02-12 Thread Jackie Li
Hardware may have specific restrictions on GuC WOPCM offset and size. On Gen9, the value of the GuC WOPCM size register needs to be larger than the value of GuC WOPCM offset register + a Gen9 specific offset (144KB) for reserved GuC WOPCM. Fail to enforce such a restriction on GuC WOPCM size will