Re: [Intel-gfx] [PATCH v2 04/10] drm: Add Gamma correction structure

2015-06-18 Thread Emil Velikov
On 14 June 2015 at 10:02, Sharma, Shashank shashank.sha...@intel.com wrote: Hi, Emil Velikov The reason behind a zero sized array is that we want to use the same variable for various color correction possible across various driver . Due to current blob implementation, it doesn’t look very

Re: [Intel-gfx] [PATCH v2 04/10] drm: Add Gamma correction structure

2015-06-14 Thread Sharma, Shashank
Hi, Emil Velikov The reason behind a zero sized array is that we want to use the same variable for various color correction possible across various driver . Due to current blob implementation, it doesn’t look very efficient to have another pointer in the structure, so we are left with this

Re: [Intel-gfx] [PATCH v2 04/10] drm: Add Gamma correction structure

2015-06-12 Thread Emil Velikov
Hi Kausal Malladi, On 5 June 2015 at 13:00, Jindal, Sonika sonika.jin...@intel.com wrote: On 6/4/2015 7:12 PM, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com ... v2: Addressing Daniel Stone's comment, added a variable sized array to carry Gamma correction values as blob

Re: [Intel-gfx] [PATCH v2 04/10] drm: Add Gamma correction structure

2015-06-09 Thread Damien Lespiau
On Thu, Jun 04, 2015 at 07:12:35PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch adds a new structure in DRM layer for Gamma color correction. This structure will be used by all user space agents to configure appropriate Gamma precision and Gamma

Re: [Intel-gfx] [PATCH v2 04/10] drm: Add Gamma correction structure

2015-06-08 Thread Matt Roper
On Sat, Jun 06, 2015 at 05:21:41PM +0530, Sharma, Shashank wrote: Regards Shashank On 6/6/2015 6:30 AM, Matt Roper wrote: On Thu, Jun 04, 2015 at 07:12:35PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch adds a new structure in DRM layer for Gamma

Re: [Intel-gfx] [PATCH v2 04/10] drm: Add Gamma correction structure

2015-06-06 Thread Sharma, Shashank
Regards Shashank On 6/6/2015 6:30 AM, Matt Roper wrote: On Thu, Jun 04, 2015 at 07:12:35PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch adds a new structure in DRM layer for Gamma color correction. This structure will be used by all user space agents

Re: [Intel-gfx] [PATCH v2 04/10] drm: Add Gamma correction structure

2015-06-05 Thread Malladi, Kausal
Hi Sonika, Please find my responses inline. Thanks, Kausal On Friday 05 June 2015 05:30 PM, Jindal, Sonika wrote: On 6/4/2015 7:12 PM, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch adds a new structure in DRM layer for Gamma color correction. This

Re: [Intel-gfx] [PATCH v2 04/10] drm: Add Gamma correction structure

2015-06-05 Thread Jindal, Sonika
On 6/4/2015 7:12 PM, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch adds a new structure in DRM layer for Gamma color correction. This structure will be used by all user space agents to configure appropriate Gamma precision and Gamma level. struct

Re: [Intel-gfx] [PATCH v2 04/10] drm: Add Gamma correction structure

2015-06-05 Thread Matt Roper
On Thu, Jun 04, 2015 at 07:12:35PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch adds a new structure in DRM layer for Gamma color correction. This structure will be used by all user space agents to configure appropriate Gamma precision and Gamma